Bug 179471

Summary:

REGRESSION(r224566): [GTK] 26 new timeouts on inspector related tests.

Product:

WebKit

Reporter:

Carlos Alberto Lopez Perez <clopez>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, bugs-noreply, cgarcia, darin, joepeck, mcatanzaro

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=179419

Bug Depends on:

Bug Blocks:

179317

Attachments:

Description	Flags
Patch	darin: review+

Carlos Alberto Lopez Perez

Reported 2017-11-09 03:13:13 PST

Revision r224566 <https://trac.webkit.org/r224566> caused ~26 unexpected inspector related test timeouts Regressions: Unexpected timeouts (26) inspector/console/console-message.html [ Timeout ] inspector/console/console-time.html [ Timeout ] inspector/console/heapSnapshot.html [ Timeout ] inspector/console/js-source-locations.html [ Timeout ] inspector/console/x-frame-options-message.html [ Timeout ] inspector/heap/tracking.html [ Timeout ] inspector/layers/layers-anonymous.html [ Timeout ] inspector/layers/layers-blending-compositing-reasons.html [ Timeout ] inspector/layers/layers-compositing-reasons.html [ Timeout ] inspector/layers/layers-for-node.html [ Timeout ] inspector/layers/layers-generated-content.html [ Timeout ] inspector/layers/layers-reflected-content.html [ Timeout ] inspector/memory/tracking.html [ Timeout ] inspector/page/media-query-list-listener-exception.html [ Timeout ] inspector/protocol/backend-dispatcher-argument-errors.html [ Timeout ] inspector/protocol/backend-dispatcher-malformed-message-errors.html [ Timeout ] inspector/runtime/CommandLineAPI-inspect.html [ Timeout ] inspector/script-profiler/event-type-API.html [ Timeout ] inspector/script-profiler/event-type-Microtask.html [ Timeout ] inspector/script-profiler/event-type-Other.html [ Timeout ] inspector/script-profiler/tracking.html [ Timeout ] inspector/unit-tests/async-test-suite.html [ Timeout ] inspector/unit-tests/protocol-test-dispatch-event-to-frontend.html [ Timeout ] inspector/unit-tests/sync-test-suite.html [ Timeout ] inspector/worker/worker-create-and-terminate.html [ Timeout ] inspector/worker/worker-recover-if-inspector-close.html [ Timeout ] I have double checked this by reverting r224566 locally (this test pass with this reverted)

Attachments
Patch (5.31 KB, patch) 2017-11-10 00:51 PST, Carlos Garcia Campos	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2017-11-10 00:51:56 PST

Created attachment 326568 [details] Patch

Carlos Alberto Lopez Perez

Comment 2 2017-11-10 04:48:55 PST

Comment on attachment 326568 [details] Patch From my un-expertise on the webinspector, the patch looks fine ... However I wonder why this (as well as bug 179419 which was fixed with a very similar patch) is not happening on the Mac port??? It will be helpful if someone with more expertise in this code can review it.

Blaze Burg

Comment 3 2017-11-10 10:00:14 PST

Comment on attachment 326568 [details] Patch r=me as well, I'm not sure that TestStub was minified before for Mac, but I guess there is no harm in it.

Carlos Garcia Campos

Comment 4 2017-11-12 23:41:26 PST

Committed r224745: <https://trac.webkit.org/changeset/224745>

Note You need to log in before you can comment on or make changes to this bug.