| Summary: | Include a more complete block signature in public headers to avoid potential -Wstrict-prototypes warnings | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | WebKit API | Assignee: | Joseph Pecoraro <joepeck> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | beidson, commit-queue, joepeck, mitz, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=180757 | ||||||
| Attachments: |
|
||||||
Created attachment 326427 [details]
[PATCH] Proposed Fix
Comment on attachment 326427 [details] [PATCH] Proposed Fix Clearing flags on attachment: 326427 Committed r224619: <https://trac.webkit.org/changeset/224619> All reviewed patches have been landed. Closing bug. |
Sometimes when building against a local build of WebKit I see errors like: > WKHTTPCookieStore.h:59:78: error: this block declaration is not a prototype [-Werror,-Wstrict-prototypes] > - (void)setCookie:(NSHTTPCookie *)cookie completionHandler:(nullable void (^)())completionHandler; > ^ > void > WKHTTPCookieStore.h:64:81: error: this block declaration is not a prototype [-Werror,-Wstrict-prototypes] > - (void)deleteCookie:(NSHTTPCookie *)cookie completionHandler:(nullable void (^)())completionHandler; > ^ > void > 2 errors generated. We can address this my providing a by providing a better block signature, more in line with other WebKit void block signatures.