Bug 179466 – Include a more complete block signature in public headers to avoid potential -Wstrict-prototypes warnings

• Component: WebKit API
• Status: RESOLVED FIXED

[Joseph Pecoraro]

Sometimes when building against a local build of WebKit I see errors like:

> WKHTTPCookieStore.h:59:78: error: this block declaration is not a prototype [-Werror,-Wstrict-prototypes]
> - (void)setCookie:(NSHTTPCookie *)cookie completionHandler:(nullable void (^)())completionHandler;
>                                                                              ^
>                                                                               void
> WKHTTPCookieStore.h:64:81: error: this block declaration is not a prototype [-Werror,-Wstrict-prototypes]
> - (void)deleteCookie:(NSHTTPCookie *)cookie completionHandler:(nullable void (^)())completionHandler;
>                                                                                 ^
>                                                                                  void
> 2 errors generated.

We can address this my providing a by providing a better block signature, more in line with other WebKit void block signatures.

[Joseph Pecoraro]

Created attachment 326427 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 326427 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 326427

Committed r224619: <https://trac.webkit.org/changeset/224619>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35562189>