Bug 179453 – Add Windows powershell EWS script

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Don Olmstead]

Currently everything runs through shell scripts which requires cygwin. Add a Powershell equivalent for Windows

[Don Olmstead]

Created attachment 326399 [details]
Patch

[Brent Fulgham]

Comment on attachment 326399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326399&action=review

I think this looks fine as a new direction, especially since it doesn't affect or existing tooling at all. I had a couple of minor questions about paths that I'd like you to confirm before landing.

> Tools/EWSTools/Start-Queue.ps1:47
> +    git clean -f; # Remove any left-over layout test results, added files, etc.

Does Powershell know where to find 'git'? Or do we need to make sure it's now part of the user's path? Can this script complain if 'git' is not in the path?

> Tools/EWSTools/Start-Queue.ps1:88
> +    python /Tools/BuildSlaveSupport/kill-old-processes

Ditto my 'git' comments about 'perl' and 'python'. Is Powershell smart enough to find them if you installed ActiveState stuff, or do we need to document for the user that they should add relevant paths to the system environment?

[Brent Fulgham]

Comment on attachment 326399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326399&action=review

> Tools/EWSTools/Start-Queue.ps1:86
> +    perl ./Tools/Scripts/update-webkit --no-auxiliary-libs;

Does Powershell always do the right thing with Unix-style paths? That's a very nice feature!

[Don Olmstead]

(In reply to Brent Fulgham from comment #2)
> Comment on attachment 326399 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326399&action=review
> 
> I think this looks fine as a new direction, especially since it doesn't
> affect or existing tooling at all. I had a couple of minor questions about
> paths that I'd like you to confirm before landing.
> 
> > Tools/EWSTools/Start-Queue.ps1:47
> > +    git clean -f; # Remove any left-over layout test results, added files, etc.
> 
> Does Powershell know where to find 'git'? Or do we need to make sure it's
> now part of the user's path? Can this script complain if 'git' is not in the
> path?
> 
> > Tools/EWSTools/Start-Queue.ps1:88
> > +    python /Tools/BuildSlaveSupport/kill-old-processes
> 
> Ditto my 'git' comments about 'perl' and 'python'. Is Powershell smart
> enough to find them if you installed ActiveState stuff, or do we need to
> document for the user that they should add relevant paths to the system
> environment?

We're assuming that its on the path and accessible.

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 326399 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326399&action=review
> 
> > Tools/EWSTools/Start-Queue.ps1:86
> > +    perl ./Tools/Scripts/update-webkit --no-auxiliary-libs;
> 
> Does Powershell always do the right thing with Unix-style paths? That's a
> very nice feature!

Yep it works fine.

[WebKit Commit Bot]

Comment on attachment 326399 [details]
Patch

Clearing flags on attachment: 326399

Committed r224610: <https://trac.webkit.org/changeset/224610>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35562177>