Bug 179419

Summary: REGRESSION(r224566): [GTK][WPE] Many inspector tests are failing after r224566
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboya, bburg, bugs-noreply, clopez, commit-queue, joepeck
Priority: P2 Keywords: Gtk, LayoutTestFailure, Regression
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=161212
https://bugs.webkit.org/show_bug.cgi?id=179471
Attachments:
Description Flags
Patch none

Description Carlos Garcia Campos 2017-11-08 01:39:35 PST 
All of them fail with the following error:

Uncaught exception in Inspector page: ReferenceError: Can't find variable: CodeMirror [TestCombined.js:36658:15]

This is because Test.html, even when combined, is trying to load CodeMirror from External/CodeMirror, but CodeMirror was already combined for Main.html. We need to also combine CodeMirror for Test.html. I don't know why this works in Mac.
Comment 1 Carlos Garcia Campos 2017-11-08 01:42:00 PST 
Created attachment 326316 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-11-08 03:43:59 PST 
Joe, Brian I guess this is ok for Mac too, at least EWS didn't complain.
Comment 3 Carlos Garcia Campos 2017-11-08 23:48:17 PST 
*** Bug 179430 has been marked as a duplicate of this bug. ***
Comment 4 Carlos Garcia Campos 2017-11-08 23:51:27 PST 
Comment on attachment 326316 [details]
Patch

Ok, I'm landing this because it broke many tests. Joe, Brian if you have any objection or comment I'll fix it in a follow up.
Comment 5 WebKit Commit Bot 2017-11-09 00:12:07 PST 
Comment on attachment 326316 [details]
Patch

Clearing flags on attachment: 326316

Committed r224621: <https://trac.webkit.org/changeset/224621>
Comment 6 WebKit Commit Bot 2017-11-09 00:12:09 PST 
All reviewed patches have been landed.  Closing bug.