Bug 179345

Summary: [WinCairo] Treat 'future' version correctly
Product: WebKit Reporter: Basuke Suzuki <Basuke.Suzuki>
Component: Tools / TestsAssignee: Basuke Suzuki <Basuke.Suzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, Basuke.Suzuki, buildbot, commit-queue, don.olmstead, glenn, Hironori.Fujii, lforschler, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 179216    
Attachments:
Description Flags
patch
buildbot: commit-queue-
Archive of layout-test-results from ews124 for ios-simulator-wk2
none
patch none

Description Basuke Suzuki 2017-11-06 14:22:06 PST
It just causes error currently if os_version detection falls into 'future'.
Comment 1 Basuke Suzuki 2017-11-07 17:49:44 PST
Created attachment 326280 [details]
patch
Comment 2 Basuke Suzuki 2017-11-07 17:51:12 PST
WinPort has many adhoc implementations. To make the original purpose of those method clear, WinCairo is starting over with ApplePort which has basic OS version handling.

Upcoming patches will make the method of WinPort to be usable from WinCairoPort by making those separate library or at least @static.
Comment 3 Build Bot 2017-11-07 19:57:58 PST
Comment on attachment 326280 [details]
patch

Attachment 326280 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5141993

New failing tests:
http/tests/workers/service/service-worker-clear.html
Comment 4 Build Bot 2017-11-07 19:57:59 PST
Created attachment 326293 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 5 Basuke Suzuki 2017-11-09 12:12:18 PST
Created attachment 326476 [details]
patch
Comment 6 Basuke Suzuki 2017-11-09 12:13:14 PST
Stop reconstructing the port class from the scratch. Just fix the issue.
Comment 7 WebKit Commit Bot 2017-11-10 16:18:34 PST
Comment on attachment 326476 [details]
patch

Clearing flags on attachment: 326476

Committed r224713: <https://trac.webkit.org/changeset/224713>
Comment 8 WebKit Commit Bot 2017-11-10 16:18:35 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-11-15 09:42:33 PST
<rdar://problem/35562283>