Summary: | [Win] Add WebKitQuartzCoreAdditions library. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||
Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, bfulgham, buildbot, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Per Arne Vollan
2017-11-06 10:31:22 PST
Created attachment 326162 [details]
Patch
Attachment 326162 [details] did not pass style-queue:
ERROR: Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CAView.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/Image.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/API/WKCACFView.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/API/WKCACFImage.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CVDisplayLink.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CMakeLists.txt:22: Alphabetical sorting problem. "CAD3DRenderer.cpp" should be before "API/WebKitQuartzCoreAdditions.cpp". [list/order] [5]
ERROR: Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:316: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4]
ERROR: Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/ImageConversion.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/ImageConversion.cpp:107: Use the class HWndDC instead of calling GetDC to avoid potential memory leaks. [runtime/leaky_pattern] [5]
ERROR: Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 11 in 27 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 326162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326162&action=review > Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CMakeLists.txt:52 > +if (${CMAKE_GENERATOR} MATCHES "Ninja") This check doesn’t seem to do anything different. > Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CMakeLists.txt:66 > +add_library(WebKitQuartzCoreAdditions SHARED ${WebKitQuartzCoreAdditions_SOURCES}) Is it a dll? (In reply to Alex Christensen from comment #3) > Comment on attachment 326162 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326162&action=review > > > Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CMakeLists.txt:52 > > +if (${CMAKE_GENERATOR} MATCHES "Ninja") > > This check doesn’t seem to do anything different. > Good catch! I'll fix this before landing. > > Source/WebKitLegacy/win/WebKitQuartzCoreAdditions/CMakeLists.txt:66 > > +add_library(WebKitQuartzCoreAdditions SHARED ${WebKitQuartzCoreAdditions_SOURCES}) > > Is it a dll? Yes. Thanks for reviewing! Committed r224629: <https://trac.webkit.org/changeset/224629/webkit>. |