Bug 179286

Summary: Add a GraphicsContextImpl and use it for DispayList::Recorder
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, dino, mmaxfield, sabouhallawa, sam, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
sam: review+
Patch none

Simon Fraser (smfr)
Reported 2017-11-04 12:20:35 PDT
Add a GraphicsContextImpl and use it for DispayList::Recorder
Attachments
Patch (64.15 KB, patch)
2017-11-04 12:22 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (76.08 KB, patch)
2017-11-04 12:57 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (79.05 KB, patch)
2017-11-04 13:28 PDT, Simon Fraser (smfr) 		sam: review+
DetailsFormatted DiffDiff
Patch (79.83 KB, patch)
2017-11-04 15:36 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2017-11-04 12:22:36 PDT
Created attachment 326033 [details] Patch
Build Bot
Comment 2 2017-11-04 12:26:05 PDT
Attachment 326033 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1553: Missing space before { [whitespace/braces] [5] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 3 2017-11-04 12:57:18 PDT
Created attachment 326036 [details] Patch
Build Bot
Comment 4 2017-11-04 12:59:28 PDT
Attachment 326036 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1553: Missing space before { [whitespace/braces] [5] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 5 2017-11-04 13:28:24 PDT
Created attachment 326038 [details] Patch
Simon Fraser (smfr)
Comment 6 2017-11-04 15:36:50 PDT
Created attachment 326047 [details] Patch
WebKit Commit Bot
Comment 7 2017-11-04 16:43:59 PDT
Comment on attachment 326047 [details] Patch Clearing flags on attachment: 326047 Committed r224463: <https://trac.webkit.org/changeset/224463>
Radar WebKit Bug Importer
Comment 8 2017-11-15 09:41:59 PST
<rdar://problem/35562254>
Note You need to log in before you can comment on or make changes to this bug.