Bug 179252

Summary: [GTK] Fix gtk-doc generation with gtk-doc master
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, commit-queue, mcatanzaro
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
See Also: https://bugzilla.gnome.org/show_bug.cgi?id=789800
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2017-11-03 11:49:56 PDT
gtkdoc-scangobj has changed to no longer use a shell when executing its subcommands. In particular, this means we can no longer rely on shell stuff in our run command that we use to run the scanner. See https://bugzilla.gnome.org/show_bug.cgi?id=789800. We currently use the RUN envvar to set LD_LIBRARY_PATH, and the end result is gtkdoc-scangobj attempts to execute our environment variable instead of the scanner itself. Oops. I've tested by replacing the run command with a little script that just prints its environment, and LD_LIBRARY_PATH gets passed down successfully to the child, so I'm not sure why we're using RUN here to set it. (Maybe it was needed for the old Perl version of gtk-doc?) Anyway, we can just set LD_LIBRARY_PATH directly, instead of using RUN, in order to make doc generation work again.
Attachments
Patch (2.43 KB, patch)
2017-11-03 11:52 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2017-11-03 11:52:09 PDT
Created attachment 325929 [details] Patch
WebKit Commit Bot
Comment 2 2017-11-04 09:47:49 PDT
Comment on attachment 325929 [details] Patch Clearing flags on attachment: 325929 Committed r224458: <https://trac.webkit.org/changeset/224458>
WebKit Commit Bot
Comment 3 2017-11-04 09:47:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.