Bug 179225

Summary: Web Inspector: Uncaught Exception: null is not an object (evaluating 'selector.specificity.map')​ (at SpreadsheetCSSStyleDeclarationSection.js:​199:​51)​
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
joepeck: review+, joepeck: commit-queue+
Patch none

Joseph Pecoraro
Reported 2017-11-02 19:31:16 PDT
Inspected an element using the element search and got an exception: TypeError:​ null is not an object (evaluating 'selector.specificity.map')​ (at SpreadsheetCSSStyleDeclarationSection.js:​199:​51)​ appendSelector @ SpreadsheetCSSStyleDeclarationSection.js:​199:​51 _renderSelector @ SpreadsheetCSSStyleDeclarationSection.js:​236:​35 layout @ SpreadsheetCSSStyleDeclarationSection.js:​109:​29 _layoutSubtree @ View.js:​278:​20 _visitViewTreeForLayout @ View.js:​374:​36
Attachments
Patch (2.04 KB, patch)
2017-11-03 15:44 PDT, Nikita Vasilyev 		joepeck: review+
joepeck: commit-queue+
DetailsFormatted DiffDiff
Patch (1.99 KB, patch)
2017-11-03 16:11 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-11-02 19:32:01 PDT
Inspect the inspector and inspect any DOM node <li> => exception.
Radar WebKit Bug Importer
Comment 2 2017-11-02 19:32:28 PDT
<rdar://problem/35329019>
Blaze Burg
Comment 3 2017-11-02 20:35:39 PDT
o_O
Nikita Vasilyev
Comment 4 2017-11-03 15:16:17 PDT
"using the element search" — using the bull eye icon, i.e. "Start element selection (⇧⌘C)"? I can't reproduce it. Would be great if you can show it on your machine.
Nikita Vasilyev
Comment 5 2017-11-03 15:24:03 PDT
I reproduced it :|
Nikita Vasilyev
Comment 6 2017-11-03 15:44:19 PDT
Created attachment 325976 [details] Patch
Joseph Pecoraro
Comment 7 2017-11-03 15:50:26 PDT
Comment on attachment 325976 [details] Patch r=me
Joseph Pecoraro
Comment 8 2017-11-03 15:51:21 PDT
Comment on attachment 325976 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325976&action=review > Source/WebInspectorUI/ChangeLog:12 > + Check if selector.specificity is falsy, the same way as in the old styles sidebar > + (defined in WI.CSSStyleDeclarationSection.prototype.refresh). A better comment would not describe what the if check is doing (its obviously checking for a truthy value), but would describe why the if check is necessary (sometimes the specificity does not exist because ....)
Nikita Vasilyev
Comment 9 2017-11-03 16:11:58 PDT
Created attachment 325982 [details] Patch
WebKit Commit Bot
Comment 10 2017-11-03 16:31:53 PDT
Comment on attachment 325982 [details] Patch Clearing flags on attachment: 325982 Committed r224441: <https://trac.webkit.org/changeset/224441>
WebKit Commit Bot
Comment 11 2017-11-03 16:31:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.