Summary: | Layout Test js/intl-datetimeformat.html is failing on High Sierra (GMT vs. UTC) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Lewis <jlewis3> | ||||
Component: | Tools / Tests | Assignee: | Andy VanWagoner <andy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andy, ap, commit-queue, darin, lforschler, pvollan, ryanhaddad, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Matt Lewis
2017-11-02 15:52:38 PDT
Marked as failing for now on High Sierra: https://trac.webkit.org/changeset/224411/webkit/ This is the expected result going forward, updated in 2017c.1.0 time zone asset. We'll be getting this result in macOS High Sierra and in iOS 10+ whenever the update is installed (not sure if this works in simulator). Eventually, this data will be part of TZ data installed with the OS of course. Cf. <rdar://problem/35415193> This test also runs as part of jsc-layout-tests, where I don't think we can add platform-specific expectation files. A couple ideas: - The test can be modified to accept either GMT or UTC. - It can be skipped as a JSC test, I don't think that it provides much vakue being run twice. Normally, JSC tests are good to run as such because of all the different modes, but this one is unlikely to run differently in different modes. Both should be considered correct. I think the test should be updated to accept either GMT or UTC. Created attachment 327368 [details]
Avoid testing against UTC text name since it can be ambiguous.
Comment on attachment 327368 [details]
Avoid testing against UTC text name since it can be ambiguous.
When I got into updating the test it seemed like it would be harder to understand allowing both GMT and UTC variations. I thought it would be less fragile if we test against time zones that are less ambiguous.
Comment on attachment 327368 [details]
Avoid testing against UTC text name since it can be ambiguous.
Seems OK. Too bad that the change in the operating system name for the time zone is visible as a difference in web browser behavior. Not great.
Comment on attachment 327368 [details] Avoid testing against UTC text name since it can be ambiguous. Clearing flags on attachment: 327368 Committed r225059: <https://trac.webkit.org/changeset/225059> All reviewed patches have been landed. Closing bug. |