Bug 179169 – [WPE][JHBuild] Update WPEBackend and WPEBackend-mesa

• Component: WPE WebKit
• Status: RESOLVED FIXED

[Carlos Alberto Lopez Perez]

Update WPEBackend and WPEBackend-mesa to last master.


WPEBackend (master) $ git log --oneline 5e2a29d2ccc637f7122ba72c1d62ef669b42f05c..master
3013faa Properly find EGL and pass any flag defined on the EGL pkgconfig
0272534 Merge pull request #5 from JPEWdev/license
3cd82aa Add license file
baa960b Merge pull request #2 from blino/backend-load-error
afe28ad wpe_view_backend_create: fail early if backend can not be loaded
4aff0ea Merge pull request #1 from vertexodessa/cmake28
98e3006 CMake version 2.8 is enough for the build

WPEBackend-mesa (master) $ git log --oneline 0286aed84a09120de16c3ab08bdf83c91d4a1754..master
ce2a0ad Merge pull request #7 from clopez/xdg-shell-protocol-match
1a91ded Merge pull request #5 from clopez/FindWaylandEGL
26a019a Only try to create the xdg-surface once.
c7feee8 [WPEBackend-mesa] Correctly find libxkbcommon
07e5180 Find EGL and set definitions.
a0519c6 Add missing FindWaylandEGL cmake file.

[Carlos Alberto Lopez Perez]

Created attachment 325714 [details]
Patch

[Michael Catanzaro]

Comment on attachment 325714 [details]
Patch

I thought about switching these to use git, but I think the value of being able to blame issue to particular WebKit commits outweighs the convenience of not having to update the hashes here, so OK.

Thanks very much for working on this.

[Carlos Alberto Lopez Perez]

(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 325714 [details]
> Patch
> 
> I thought about switching these to use git, but I think the value of being
> able to blame issue to particular WebKit commits outweighs the convenience
> of not having to update the hashes here, so OK.
> 

I guess you meant here "switching these to _not_ use git" ? (Otherwise I don't understand what you mean)

In any case, either when using tarballs or when using git something has always to be updated on the moduleset (either be the hashsum or the git hashid).

I don't think we should be using vague references like pointing them always to "master", as that will risk introducing random breakage on the webkit build.
I think is a good practice to mandate that each update to this modules should be tested by at least one webkit developer. The best way of doing that is like now, manually updating the git hashids in a webkit commit that needs to be reviewed.

> Thanks very much for working on this.


Thanks you for the review :)

[Carlos Alberto Lopez Perez]

Comment on attachment 325714 [details]
Patch

Clearing flags on attachment: 325714

Committed r224331: <https://trac.webkit.org/changeset/224331>

[Michael Catanzaro]

(In reply to Carlos Alberto Lopez Perez from comment #3)
> I guess you meant here "switching these to _not_ use git" ? (Otherwise I
> don't understand what you mean)

No, I just read the commit too quickly. Anyway, I agree with your reasoning!

[Michael Catanzaro]

Forgot to close it?