Summary: | [Service Workers] Add initial implementation for try Clear Registration / Clear Registration algorithms | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | beidson, ggaren, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris Dumez
2017-11-01 19:38:57 PDT
Created attachment 325666 [details]
Patch
Comment on attachment 325666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325666&action=review > Source/WebCore/workers/service/server/SWServerJobQueue.cpp:78 > // If newestWorker is null, invoke Clear Registration algorithm passing this registration as its argument. Do we need that comment? It is pretty clear from the code already. Ditto below. (In reply to youenn fablet from comment #2) > Comment on attachment 325666 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=325666&action=review > > > Source/WebCore/workers/service/server/SWServerJobQueue.cpp:78 > > // If newestWorker is null, invoke Clear Registration algorithm passing this registration as its argument. > > Do we need that comment? It is pretty clear from the code already. Ditto > below. It is the pattern in this file to copy/paste the spec text that matches the code. Comment on attachment 325666 [details] Patch Clearing flags on attachment: 325666 Committed r224337: <https://trac.webkit.org/changeset/224337> All reviewed patches have been landed. Closing bug. |