Bug 179151 – [Service Workers] Add initial implementation for try Clear Registration / Clear Registration algorithms

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Chris Dumez]

[Service Workers] Add initial implementation for try Clear Registration / Clear Registration algorithms:
- https://w3c.github.io/ServiceWorker/#try-clear-registration
- https://w3c.github.io/ServiceWorker/#clear-registration

[Chris Dumez]

Created attachment 325666 [details]
Patch

[youenn fablet]

Comment on attachment 325666 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325666&action=review

> Source/WebCore/workers/service/server/SWServerJobQueue.cpp:78
>          // If newestWorker is null, invoke Clear Registration algorithm passing this registration as its argument.

Do we need that comment? It is pretty clear from the code already. Ditto below.

[Chris Dumez]

(In reply to youenn fablet from comment #2)
> Comment on attachment 325666 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=325666&action=review
> 
> > Source/WebCore/workers/service/server/SWServerJobQueue.cpp:78
> >          // If newestWorker is null, invoke Clear Registration algorithm passing this registration as its argument.
> 
> Do we need that comment? It is pretty clear from the code already. Ditto
> below.

It is the pattern in this file to copy/paste the spec text that matches the code.

[Chris Dumez]

Comment on attachment 325666 [details]
Patch

Clearing flags on attachment: 325666

Committed r224337: <https://trac.webkit.org/changeset/224337>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35567487>