Bug 179134

Summary:

Web Inspector: Combine all storage icon files into a single file

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none

Joseph Pecoraro

Reported 2017-11-01 12:15:46 PDT

Combine all storage icon files into a single file Its a mess to have a bunch of CSS files with a single selector in them.

Attachments
[PATCH] Proposed Fix (12.27 KB, patch) 2017-11-01 12:17 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (1.03 MB, application/zip) 2017-11-01 13:53 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2017-11-01 12:17:05 PDT

Created attachment 325611 [details] [PATCH] Proposed Fix

Devin Rousso

Comment 2 2017-11-01 13:05:36 PDT

Comment on attachment 325611 [details] [PATCH] Proposed Fix r=me. Good simplification =D

Build Bot

Comment 3 2017-11-01 13:53:04 PDT

Comment on attachment 325611 [details] [PATCH] Proposed Fix Attachment 325611 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5065797 New failing tests: imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html

Build Bot

Comment 4 2017-11-01 13:53:05 PDT

Created attachment 325627 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Joseph Pecoraro

Comment 5 2017-11-01 14:00:41 PDT

Comment on attachment 325611 [details] [PATCH] Proposed Fix Unrelated test failure.

WebKit Commit Bot

Comment 6 2017-11-01 14:04:35 PDT

Comment on attachment 325611 [details] [PATCH] Proposed Fix Clearing flags on attachment: 325611 Committed r224293: <https://trac.webkit.org/changeset/224293>

WebKit Commit Bot

Comment 7 2017-11-01 14:04:36 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2017-11-15 12:28:20 PST

<rdar://problem/35567604>

Note You need to log in before you can comment on or make changes to this bug.