|Summary:||updateMaskedAncestorShouldIsolateBlending() should check the Nullability of the computedStyle() of the element's ancestors|
|Product:||WebKit||Reporter:||Said Abou-Hallawa <sabouhallawa>|
|Component:||SVG||Assignee:||Said Abou-Hallawa <sabouhallawa>|
|Severity:||Normal||CC:||buildbot, commit-queue, rniwa, simon.fraser, webkit-bug-importer, zimmermann|
|Version:||WebKit Nightly Build|
Description Said Abou-Hallawa 2017-10-31 16:20:55 PDT
This should not happen unless recalcStyle() is called in the middle of changing the DOM tree and the render tree has not been updated yet. In this case, a renderer will be associated with an element which is not connected to the DOM tree.
Comment 3 Ryosuke Niwa 2017-10-31 17:30:18 PDT
Comment on attachment 325518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325518&action=review > Source/WebCore/ChangeLog:11 > + while the DOM tree is being changed an event fires and this event causes "DOM tree is being changed an event fires"? You mean like "a script runs in response to a DOM mutation"?
Comment 4 Build Bot 2017-10-31 17:37:03 PDT
Comment on attachment 325518 [details] Patch Attachment 325518 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5057128 New failing tests: imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html
Comment 5 Build Bot 2017-10-31 17:37:05 PDT
Created attachment 325528 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment 7 Said Abou-Hallawa 2017-10-31 18:19:27 PDT
Comment on attachment 325518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325518&action=review >> Source/WebCore/ChangeLog:11 >> + while the DOM tree is being changed an event fires and this event causes > > "DOM tree is being changed an event fires"? > You mean like "a script runs in response to a DOM mutation"? Not necessarily. For example while waiting for a response from the network process, WebKit may decide to process another message from the UI process. Processing the UI message will cause an event to fire. In this case styleReclac()/layout() may happen. I changed the ChangeLog to make the wording more generic.
Comment 8 WebKit Commit Bot 2017-10-31 18:39:12 PDT
Comment on attachment 325531 [details] Patch Clearing flags on attachment: 325531 Committed r224269: <https://trac.webkit.org/changeset/224269>
Comment 9 WebKit Commit Bot 2017-10-31 18:39:14 PDT
All reviewed patches have been landed. Closing bug.