Bug 179077

Summary: Expose already-available WKNavigationAction.request.HTTPBody through the API
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=140188
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2017-10-31 14:12:14 PDT
Encode ResourceRequests' httpBody contents over IPC
Attachments
Patch (6.16 KB, patch)
2017-10-31 14:13 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (3.69 KB, patch)
2020-06-23 10:44 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-10-31 14:13:02 PDT
Created attachment 325491 [details] Patch
Geoffrey Garen
Comment 2 2017-10-31 14:38:38 PDT
Can we post this to a perf try-bot to see its impact on benchmarks?
Geoffrey Garen
Comment 3 2017-10-31 14:48:07 PDT
Here's the patch that removed the HTTP body: <https://trac.webkit.org/changeset/144216/webkit>.
Geoffrey Garen
Comment 4 2017-10-31 14:48:25 PDT
I wonder if ap remembers what the performance test that motivated this was.
Geoffrey Garen
Comment 5 2017-10-31 14:50:41 PDT
I think it might be better for clients to use _WKInputDelegate.
Alexey Proskuryakov
Comment 6 2017-10-31 18:29:07 PDT
This was not about benchmarks, but about extreme cases. E.g. how are we going to upload videos to YouTube now?
Alexey Proskuryakov
Comment 7 2017-10-31 18:30:30 PDT
Oh, and the secondary concern was consistency - one can't encode a stream, so any feature based on seeing the content in another process will be working inconsistently.
Alex Christensen
Comment 8 2017-11-01 14:47:16 PDT
Comment on attachment 325491 [details] Patch I think this is not a good solution.
David Kilzer (:ddkilzer)
Comment 9 2020-06-22 18:41:58 PDT
<rdar://problem/35087855>
Alex Christensen
Comment 10 2020-06-23 10:44:07 PDT
Created attachment 402567 [details] Patch
EWS
Comment 11 2020-06-23 12:00:15 PDT
Committed r263411: <https://trac.webkit.org/changeset/263411> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402567 [details].
Note You need to log in before you can comment on or make changes to this bug.