Summary: | [GTK] imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html crash in in bmalloc::Heap::allocateLarge | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Charlie Turner <cturner> | ||||||||||
Component: | WebKitGTK | Assignee: | Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | benjamin, bugs-noreply, buildbot, cdumez, cmarcelo, commit-queue, dbates, Hironori.Fujii, mcatanzaro, Ms2ger | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=178984 | ||||||||||||
Bug Depends on: | 179477 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Charlie Turner
2017-10-31 03:43:48 PDT
Created attachment 325558 [details]
Patch
Comment on attachment 325558 [details] Patch Attachment 325558 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5061481 New failing tests: imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html Created attachment 325561 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 325558 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325558&action=review > Source/WebCore/ChangeLog:3 > + [GTK] Use fallible allocation in ImageBuffer::ImageBuffer(). Why? I think Zan or Miguel would be a good reviewer to ask for this. (In reply to Michael Catanzaro from comment #4) > Comment on attachment 325558 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=325558&action=review > > > Source/WebCore/ChangeLog:3 > > + [GTK] Use fallible allocation in ImageBuffer::ImageBuffer(). > > Why? > > I think Zan or Miguel would be a good reviewer to ask for this. Because of the crash this bug is filed for; web pages can easily control the size of the buffer we try to allocate here. The mac port also uses fallible allocation. WinCairo EWS is red. tryFastZeroedMalloc should be marked as WTF_EXPORT_PRIVATE. Created attachment 326569 [details]
Patch
(In reply to Ms2ger from comment #5) > Because of the crash this bug is filed for; web pages can easily control the > size of the buffer we try to allocate here. The mac port also uses fallible > allocation. OK, makes sense. Comment on attachment 326569 [details] Patch Clearing flags on attachment: 326569 Committed r224681: <https://trac.webkit.org/changeset/224681> All reviewed patches have been landed. Closing bug. *** Bug 179477 has been marked as a duplicate of this bug. *** |