Summary: | Simplify event dispatch code and make it a bit more consistent | ||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||||||||||||||||
Component: | UI Events | Assignee: | Darin Adler <darin> | ||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
Severity: | Normal | CC: | achristensen, buildbot, cdumez, commit-queue, dewei_zhu, rniwa, sam, webkit-bug-importer, wenson_hsieh | ||||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||
Attachments: |
|
Description
Darin Adler
2017-10-29 14:01:50 PDT
Created attachment 325294 [details]
Patch
Attachment 325294 [details] did not pass style-queue:
ERROR: Source/WebCore/dom/Event.h:54: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/dom/Event.h:55: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/dom/Event.h:56: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/dom/Event.h:57: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 4 in 54 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 325294 [details] Patch Attachment 325294 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5034127 New failing tests: imported/w3c/web-platform-tests/shadow-dom/event-composed-path-with-related-target.html imported/w3c/web-platform-tests/shadow-dom/event-with-related-target.html fast/events/shadow-event-path.html imported/w3c/web-platform-tests/shadow-dom/event-post-dispatch.html fast/shadow-dom/event-path-with-window.html fast/events/shadow-event-path-2.html imported/w3c/web-platform-tests/shadow-dom/Extensions-to-Event-Interface.html fast/shadow-dom/negative-tabindex-on-shadow-host.html Created attachment 325300 [details]
Archive of layout-test-results from ews103 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 325294 [details] Patch Attachment 325294 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5034113 Number of test failures exceeded the failure limit. Created attachment 325301 [details]
Archive of layout-test-results from ews117 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 325294 [details] Patch Attachment 325294 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5034180 New failing tests: imported/w3c/web-platform-tests/shadow-dom/event-composed-path-with-related-target.html imported/w3c/web-platform-tests/shadow-dom/event-with-related-target.html fast/events/shadow-event-path.html imported/w3c/web-platform-tests/shadow-dom/event-post-dispatch.html fast/shadow-dom/event-path-with-window.html fast/events/shadow-event-path-2.html imported/w3c/web-platform-tests/shadow-dom/Extensions-to-Event-Interface.html fast/shadow-dom/negative-tabindex-on-shadow-host.html Created attachment 325302 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 325294 [details] Patch Attachment 325294 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5034200 Number of test failures exceeded the failure limit. Created attachment 325304 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 325310 [details]
Patch
Attachment 325310 [details] did not pass style-queue:
ERROR: Source/WebCore/dom/Event.h:54: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/dom/Event.h:55: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/dom/Event.h:56: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/dom/Event.h:57: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 4 in 54 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 325310 [details] Patch Attachment 325310 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5035736 Number of test failures exceeded the failure limit. Created attachment 325319 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 325310 [details] Patch Attachment 325310 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5035750 New failing tests: svg/custom/bug78700.svg Created attachment 325320 [details]
Archive of layout-test-results from ews117 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 325321 [details]
Patch
Attachment 325321 [details] did not pass style-queue:
ERROR: Source/WebCore/dom/Event.h:54: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/dom/Event.h:55: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/dom/Event.h:56: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/dom/Event.h:57: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 4 in 54 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 325321 [details] Patch Attachment 325321 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5036606 Number of test failures exceeded the failure limit. Created attachment 325327 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 325678 [details]
Patch
Attachment 325678 [details] did not pass style-queue:
ERROR: Source/WebCore/dom/Event.h:54: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/dom/Event.h:55: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/dom/Event.h:56: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/dom/Event.h:57: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMEvent.cpp"
Total errors found: 4 in 56 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Hooray, passing all tests. Ready to get reviewed and land! Anyone willing to review? Comment on attachment 325678 [details]
Patch
r=me
Comment on attachment 325678 [details] Patch Rejecting attachment 325678 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 325678, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: page/EventHandler.cpp patching file Source/WebCore/page/EventHandler.h patching file Source/WebCore/platform/graphics/filters/FilterOperation.h patching file Source/WebCore/workers/WorkerMessagingProxy.cpp patching file Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMEvent.cpp patching file Source/WebKitLegacy/mac/DOM/DOMEvent.mm Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/5094095 Committed r224459: <https://trac.webkit.org/changeset/224459> This change breaks builds. Sources/WebCore/dom/EventPath.cpp:247:30: error: member function 'item' not viable: 'this' argument has type 'const WebCore::TouchList', but function is not marked const (In reply to dewei_zhu from comment #28) > This change breaks builds. > Sources/WebCore/dom/EventPath.cpp:247:30: error: member function 'item' not > viable: 'this' argument has type 'const WebCore::TouchList', but function is > not marked const I attempted to land a build fix. Will monitor. (In reply to Chris Dumez from comment #29) > (In reply to dewei_zhu from comment #28) > > This change breaks builds. > > Sources/WebCore/dom/EventPath.cpp:247:30: error: member function 'item' not > > viable: 'this' argument has type 'const WebCore::TouchList', but function is > > not marked const > > I attempted to land a build fix. Will monitor. Looks like the bots are back to green. |