Bug 178991

Summary: Simplify event dispatch code and make it a bit more consistent
Product: WebKit Reporter: Darin Adler <darin>
Component: UI EventsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, cdumez, commit-queue, dewei_zhu, rniwa, sam, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews103 for mac-elcapitan
none
Archive of layout-test-results from ews117 for mac-elcapitan
none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
Patch
none
Archive of layout-test-results from ews124 for ios-simulator-wk2
none
Archive of layout-test-results from ews117 for mac-elcapitan
none
Patch
none
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
Patch cdumez: review+, commit-queue: commit-queue-

Description Darin Adler 2017-10-29 14:01:50 PDT
Simplify event dispatch code and make it a bit more consistent
Comment 1 Darin Adler 2017-10-29 15:51:02 PDT Comment hidden (obsolete)
Comment 2 Build Bot 2017-10-29 15:54:01 PDT Comment hidden (obsolete)
Comment 3 Build Bot 2017-10-29 16:53:35 PDT Comment hidden (obsolete)
Comment 4 Build Bot 2017-10-29 16:53:36 PDT Comment hidden (obsolete)
Comment 5 Build Bot 2017-10-29 16:55:48 PDT Comment hidden (obsolete)
Comment 6 Build Bot 2017-10-29 16:55:50 PDT Comment hidden (obsolete)
Comment 7 Build Bot 2017-10-29 17:00:22 PDT Comment hidden (obsolete)
Comment 8 Build Bot 2017-10-29 17:00:23 PDT Comment hidden (obsolete)
Comment 9 Build Bot 2017-10-29 17:10:55 PDT Comment hidden (obsolete)
Comment 10 Build Bot 2017-10-29 17:10:57 PDT Comment hidden (obsolete)
Comment 11 Darin Adler 2017-10-29 19:26:06 PDT Comment hidden (obsolete)
Comment 12 Build Bot 2017-10-29 19:28:21 PDT Comment hidden (obsolete)
Comment 13 Build Bot 2017-10-29 20:46:17 PDT Comment hidden (obsolete)
Comment 14 Build Bot 2017-10-29 20:46:18 PDT Comment hidden (obsolete)
Comment 15 Build Bot 2017-10-29 20:47:53 PDT Comment hidden (obsolete)
Comment 16 Build Bot 2017-10-29 20:47:54 PDT Comment hidden (obsolete)
Comment 17 Darin Adler 2017-10-29 21:40:46 PDT Comment hidden (obsolete)
Comment 18 Build Bot 2017-10-29 21:43:39 PDT Comment hidden (obsolete)
Comment 19 Build Bot 2017-10-29 23:00:40 PDT Comment hidden (obsolete)
Comment 20 Build Bot 2017-10-29 23:00:42 PDT Comment hidden (obsolete)
Comment 21 Darin Adler 2017-11-01 21:28:23 PDT
Created attachment 325678 [details]
Patch
Comment 22 Build Bot 2017-11-01 21:31:27 PDT
Attachment 325678 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Event.h:54:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/dom/Event.h:55:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/dom/Event.h:56:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/dom/Event.h:57:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMEvent.cpp"
Total errors found: 4 in 56 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 23 Darin Adler 2017-11-02 09:17:58 PDT
Hooray, passing all tests. Ready to get reviewed and land!
Comment 24 Darin Adler 2017-11-03 07:23:35 PDT
Anyone willing to review?
Comment 25 Chris Dumez 2017-11-03 09:23:28 PDT
Comment on attachment 325678 [details]
Patch

r=me
Comment 26 WebKit Commit Bot 2017-11-03 13:01:01 PDT
Comment on attachment 325678 [details]
Patch

Rejecting attachment 325678 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 325678, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
page/EventHandler.cpp
patching file Source/WebCore/page/EventHandler.h
patching file Source/WebCore/platform/graphics/filters/FilterOperation.h
patching file Source/WebCore/workers/WorkerMessagingProxy.cpp
patching file Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMEvent.cpp
patching file Source/WebKitLegacy/mac/DOM/DOMEvent.mm

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/5094095
Comment 27 Darin Adler 2017-11-04 14:19:17 PDT
Committed r224459: <https://trac.webkit.org/changeset/224459>
Comment 28 dewei_zhu 2017-11-05 21:13:44 PST
This change breaks builds.
Sources/WebCore/dom/EventPath.cpp:247:30: error: member function 'item' not viable: 'this' argument has type 'const WebCore::TouchList', but function is not marked const
Comment 29 Chris Dumez 2017-11-05 21:22:59 PST
(In reply to dewei_zhu from comment #28)
> This change breaks builds.
> Sources/WebCore/dom/EventPath.cpp:247:30: error: member function 'item' not
> viable: 'this' argument has type 'const WebCore::TouchList', but function is
> not marked const

I attempted to land a build fix. Will monitor.
Comment 30 Chris Dumez 2017-11-05 21:37:56 PST
(In reply to Chris Dumez from comment #29)
> (In reply to dewei_zhu from comment #28)
> > This change breaks builds.
> > Sources/WebCore/dom/EventPath.cpp:247:30: error: member function 'item' not
> > viable: 'this' argument has type 'const WebCore::TouchList', but function is
> > not marked const
> 
> I attempted to land a build fix. Will monitor.

Looks like the bots are back to green.
Comment 31 Radar WebKit Bug Importer 2017-11-15 12:34:46 PST
<rdar://problem/35567812>