Bug 178991

Summary:

Simplify event dispatch code and make it a bit more consistent

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

UI Events

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, cdumez, commit-queue, dewei_zhu, rniwa, sam, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews117 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Archive of layout-test-results from ews117 for mac-elcapitan	none
Patch	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Patch	cdumez: review+, commit-queue: commit-queue-

Darin Adler

Reported 2017-10-29 14:01:50 PDT

Simplify event dispatch code and make it a bit more consistent

Attachments
Patch (129.59 KB, patch) 2017-10-29 15:51 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.04 MB, application/zip) 2017-10-29 16:53 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-elcapitan (1.45 MB, application/zip) 2017-10-29 16:55 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.24 MB, application/zip) 2017-10-29 17:00 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (1.46 MB, application/zip) 2017-10-29 17:10 PDT, Build Bot	no flags	Details
Patch (129.73 KB, patch) 2017-10-29 19:26 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (1.49 MB, application/zip) 2017-10-29 20:46 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-elcapitan (1.95 MB, application/zip) 2017-10-29 20:47 PDT, Build Bot	no flags	Details
Patch (131.49 KB, patch) 2017-10-29 21:40 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.48 MB, application/zip) 2017-10-29 23:00 PDT, Build Bot	no flags	Details
Patch (132.99 KB, patch) 2017-11-01 21:28 PDT, Darin Adler	cdumez: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2017-10-29 15:51:02 PDT Comment hidden (obsolete)

Created attachment 325294 [details] Patch

Build Bot

Comment 2 2017-10-29 15:54:01 PDT Comment hidden (obsolete)

Attachment 325294 [details] did not pass style-queue: ERROR: Source/WebCore/dom/Event.h:54: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/Event.h:55: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/Event.h:56: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/Event.h:57: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 4 in 54 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2017-10-29 16:53:35 PDT Comment hidden (obsolete)

Comment on attachment 325294 [details] Patch Attachment 325294 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5034127 New failing tests: imported/w3c/web-platform-tests/shadow-dom/event-composed-path-with-related-target.html imported/w3c/web-platform-tests/shadow-dom/event-with-related-target.html fast/events/shadow-event-path.html imported/w3c/web-platform-tests/shadow-dom/event-post-dispatch.html fast/shadow-dom/event-path-with-window.html fast/events/shadow-event-path-2.html imported/w3c/web-platform-tests/shadow-dom/Extensions-to-Event-Interface.html fast/shadow-dom/negative-tabindex-on-shadow-host.html

Build Bot

Comment 4 2017-10-29 16:53:36 PDT Comment hidden (obsolete)

Created attachment 325300 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2017-10-29 16:55:48 PDT Comment hidden (obsolete)

Comment on attachment 325294 [details] Patch Attachment 325294 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5034113 Number of test failures exceeded the failure limit.

Build Bot

Comment 6 2017-10-29 16:55:50 PDT Comment hidden (obsolete)

Created attachment 325301 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-10-29 17:00:22 PDT Comment hidden (obsolete)

Comment on attachment 325294 [details] Patch Attachment 325294 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5034180 New failing tests: imported/w3c/web-platform-tests/shadow-dom/event-composed-path-with-related-target.html imported/w3c/web-platform-tests/shadow-dom/event-with-related-target.html fast/events/shadow-event-path.html imported/w3c/web-platform-tests/shadow-dom/event-post-dispatch.html fast/shadow-dom/event-path-with-window.html fast/events/shadow-event-path-2.html imported/w3c/web-platform-tests/shadow-dom/Extensions-to-Event-Interface.html fast/shadow-dom/negative-tabindex-on-shadow-host.html

Build Bot

Comment 8 2017-10-29 17:00:23 PDT Comment hidden (obsolete)

Created attachment 325302 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2017-10-29 17:10:55 PDT Comment hidden (obsolete)

Comment on attachment 325294 [details] Patch Attachment 325294 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5034200 Number of test failures exceeded the failure limit.

Build Bot

Comment 10 2017-10-29 17:10:57 PDT Comment hidden (obsolete)

Created attachment 325304 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Darin Adler

Comment 11 2017-10-29 19:26:06 PDT Comment hidden (obsolete)

Created attachment 325310 [details] Patch

Build Bot

Comment 12 2017-10-29 19:28:21 PDT Comment hidden (obsolete)

Attachment 325310 [details] did not pass style-queue: ERROR: Source/WebCore/dom/Event.h:54: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/Event.h:55: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/Event.h:56: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/Event.h:57: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 4 in 54 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 13 2017-10-29 20:46:17 PDT Comment hidden (obsolete)

Comment on attachment 325310 [details] Patch Attachment 325310 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5035736 Number of test failures exceeded the failure limit.

Build Bot

Comment 14 2017-10-29 20:46:18 PDT Comment hidden (obsolete)

Created attachment 325319 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Build Bot

Comment 15 2017-10-29 20:47:53 PDT Comment hidden (obsolete)

Comment on attachment 325310 [details] Patch Attachment 325310 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5035750 New failing tests: svg/custom/bug78700.svg

Build Bot

Comment 16 2017-10-29 20:47:54 PDT Comment hidden (obsolete)

Created attachment 325320 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Darin Adler

Comment 17 2017-10-29 21:40:46 PDT Comment hidden (obsolete)

Created attachment 325321 [details] Patch

Build Bot

Comment 18 2017-10-29 21:43:39 PDT Comment hidden (obsolete)

Attachment 325321 [details] did not pass style-queue: ERROR: Source/WebCore/dom/Event.h:54: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/Event.h:55: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/Event.h:56: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/Event.h:57: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 4 in 54 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 19 2017-10-29 23:00:40 PDT Comment hidden (obsolete)

Comment on attachment 325321 [details] Patch Attachment 325321 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5036606 Number of test failures exceeded the failure limit.

Build Bot

Comment 20 2017-10-29 23:00:42 PDT Comment hidden (obsolete)

Created attachment 325327 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Darin Adler

Comment 21 2017-11-01 21:28:23 PDT

Created attachment 325678 [details] Patch

Build Bot

Comment 22 2017-11-01 21:31:27 PDT

Attachment 325678 [details] did not pass style-queue: ERROR: Source/WebCore/dom/Event.h:54: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/Event.h:55: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/Event.h:56: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/Event.h:57: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMEvent.cpp" Total errors found: 4 in 56 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 23 2017-11-02 09:17:58 PDT

Hooray, passing all tests. Ready to get reviewed and land!

Darin Adler

Comment 24 2017-11-03 07:23:35 PDT

Anyone willing to review?

Chris Dumez

Comment 25 2017-11-03 09:23:28 PDT

Comment on attachment 325678 [details] Patch r=me

WebKit Commit Bot

Comment 26 2017-11-03 13:01:01 PDT

Comment on attachment 325678 [details] Patch Rejecting attachment 325678 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 325678, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: page/EventHandler.cpp patching file Source/WebCore/page/EventHandler.h patching file Source/WebCore/platform/graphics/filters/FilterOperation.h patching file Source/WebCore/workers/WorkerMessagingProxy.cpp patching file Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMEvent.cpp patching file Source/WebKitLegacy/mac/DOM/DOMEvent.mm Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/5094095

Darin Adler

Comment 27 2017-11-04 14:19:17 PDT

Committed r224459: <https://trac.webkit.org/changeset/224459>

dewei_zhu

Comment 28 2017-11-05 21:13:44 PST

This change breaks builds. Sources/WebCore/dom/EventPath.cpp:247:30: error: member function 'item' not viable: 'this' argument has type 'const WebCore::TouchList', but function is not marked const

Chris Dumez

Comment 29 2017-11-05 21:22:59 PST

(In reply to dewei_zhu from comment #28) > This change breaks builds. > Sources/WebCore/dom/EventPath.cpp:247:30: error: member function 'item' not > viable: 'this' argument has type 'const WebCore::TouchList', but function is > not marked const I attempted to land a build fix. Will monitor.

Chris Dumez

Comment 30 2017-11-05 21:37:56 PST

(In reply to Chris Dumez from comment #29) > (In reply to dewei_zhu from comment #28) > > This change breaks builds. > > Sources/WebCore/dom/EventPath.cpp:247:30: error: member function 'item' not > > viable: 'this' argument has type 'const WebCore::TouchList', but function is > > not marked const > > I attempted to land a build fix. Will monitor. Looks like the bots are back to green.

Radar WebKit Bug Importer

Comment 31 2017-11-15 12:34:46 PST

<rdar://problem/35567812>

Note You need to log in before you can comment on or make changes to this bug.