Summary: | Create watchlist for files related WebInspector Recording | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||
Component: | Tools / Tests | Assignee: | Devin Rousso <hi> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, glenn, joepeck, lforschler, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Devin Rousso
2017-10-27 16:48:41 PDT
Created attachment 325218 [details]
Patch
Attachment 325218 [details] did not pass style-queue:
ERROR: Tools/Scripts/webkitpy/common/config/watchlist:0: In section "CC_RULES", the following definitions are not used and should be removed: WebRTC [watchlist/general] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 325221 [details]
Patch
Attachment 325221 [details] did not pass style-queue:
ERROR: Tools/Scripts/webkitpy/common/config/watchlist:0: In section "CC_RULES", the following definitions are not used and should be removed: WebRTC [watchlist/general] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 325223 [details]
Patch
Attachment 325223 [details] did not pass style-queue:
ERROR: Tools/Scripts/webkitpy/common/config/watchlist:0: In section "CC_RULES", the following definitions are not used and should be removed: WebRTC [watchlist/general] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 325223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325223&action=review r=me > Tools/Scripts/webkitpy/common/config/watchlist:195 > + r"|Source/WebCore/bindings/js/CallTracer.*" > + r"|Source/WebCore/inspector/Recording.*" > + r"|Source/WebInspectorUI/UserInterface/\w*/Recording.*.js" > + # Canvas > + r"|Source/WebCore/inspector/InspectorCanvas.*" > + r"|Source/WebCore/html/canvas/Canvas.*.idl" > + r"|Source/WebCore/html/canvas/WebGLRenderingContext.idl" > + r"|Source/WebCore/html/canvas/WebGLRenderingContextBase.idl" Nit: I believe we normally put a trailing comma after the last value. Nit: For all the dots that are literal dots (like right before the file extension) you should escape. For example `\.idl` and `\.js`. Nit: I think all of these ending in ".*" are unnecessary, but I do see some existing examples so feel free to keep. Created attachment 325227 [details]
Patch
Attachment 325227 [details] did not pass style-queue:
ERROR: Tools/Scripts/webkitpy/common/config/watchlist:0: In section "CC_RULES", the following definitions are not used and should be removed: WebRTC [watchlist/general] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 325227 [details] Patch Clearing flags on attachment: 325227 Committed r224140: <https://trac.webkit.org/changeset/224140> All reviewed patches have been landed. Closing bug. |