Bug 178965 – Create watchlist for files related WebInspector Recording

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Devin Rousso]

A few times now, changes have been made to InspectorCanvas that should also be reflected in the frontend, but have not due to a lack of awareness.  This should help fix that.  :)

[Devin Rousso]

Created attachment 325218 [details]
Patch

[Build Bot]

Attachment 325218 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/watchlist:0:  In section "CC_RULES", the following definitions are not used and should be removed: WebRTC  [watchlist/general] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Devin Rousso]

Created attachment 325221 [details]
Patch

[Build Bot]

Attachment 325221 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/watchlist:0:  In section "CC_RULES", the following definitions are not used and should be removed: WebRTC  [watchlist/general] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Devin Rousso]

Created attachment 325223 [details]
Patch

[Build Bot]

Attachment 325223 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/watchlist:0:  In section "CC_RULES", the following definitions are not used and should be removed: WebRTC  [watchlist/general] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Comment on attachment 325223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325223&action=review

r=me

> Tools/Scripts/webkitpy/common/config/watchlist:195
> +                        r"|Source/WebCore/bindings/js/CallTracer.*"
> +                        r"|Source/WebCore/inspector/Recording.*"
> +                        r"|Source/WebInspectorUI/UserInterface/\w*/Recording.*.js"
> +                        # Canvas
> +                        r"|Source/WebCore/inspector/InspectorCanvas.*"
> +                        r"|Source/WebCore/html/canvas/Canvas.*.idl"
> +                        r"|Source/WebCore/html/canvas/WebGLRenderingContext.idl"
> +                        r"|Source/WebCore/html/canvas/WebGLRenderingContextBase.idl"

Nit: I believe we normally put a trailing comma after the last value.
Nit: For all the dots that are literal dots (like right before the file extension) you should escape. For example `\.idl` and `\.js`.
Nit: I think all of these ending in ".*" are unnecessary, but I do see some existing examples so feel free to keep.

[Devin Rousso]

Created attachment 325227 [details]
Patch

[Build Bot]

Attachment 325227 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/watchlist:0:  In section "CC_RULES", the following definitions are not used and should be removed: WebRTC  [watchlist/general] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 325227 [details]
Patch

Clearing flags on attachment: 325227

Committed r224140: <https://trac.webkit.org/changeset/224140>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35568157>