Bug 178965

Summary: Create watchlist for files related WebInspector Recording
Product: WebKit Reporter: Devin Rousso <drousso>
Component: Tools / TestsAssignee: Devin Rousso <drousso>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, glenn, joepeck, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Devin Rousso 2017-10-27 16:48:41 PDT
A few times now, changes have been made to InspectorCanvas that should also be reflected in the frontend, but have not due to a lack of awareness.  This should help fix that.  :)
Comment 1 Devin Rousso 2017-10-27 16:50:05 PDT
Created attachment 325218 [details]
Patch
Comment 2 Build Bot 2017-10-27 16:53:27 PDT
Attachment 325218 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/watchlist:0:  In section "CC_RULES", the following definitions are not used and should be removed: WebRTC  [watchlist/general] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Devin Rousso 2017-10-27 17:03:55 PDT
Created attachment 325221 [details]
Patch
Comment 4 Build Bot 2017-10-27 17:05:03 PDT
Attachment 325221 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/watchlist:0:  In section "CC_RULES", the following definitions are not used and should be removed: WebRTC  [watchlist/general] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Devin Rousso 2017-10-27 17:20:27 PDT
Created attachment 325223 [details]
Patch
Comment 6 Build Bot 2017-10-27 17:23:28 PDT
Attachment 325223 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/watchlist:0:  In section "CC_RULES", the following definitions are not used and should be removed: WebRTC  [watchlist/general] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Joseph Pecoraro 2017-10-27 17:29:13 PDT
Comment on attachment 325223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325223&action=review

r=me

> Tools/Scripts/webkitpy/common/config/watchlist:195
> +                        r"|Source/WebCore/bindings/js/CallTracer.*"
> +                        r"|Source/WebCore/inspector/Recording.*"
> +                        r"|Source/WebInspectorUI/UserInterface/\w*/Recording.*.js"
> +                        # Canvas
> +                        r"|Source/WebCore/inspector/InspectorCanvas.*"
> +                        r"|Source/WebCore/html/canvas/Canvas.*.idl"
> +                        r"|Source/WebCore/html/canvas/WebGLRenderingContext.idl"
> +                        r"|Source/WebCore/html/canvas/WebGLRenderingContextBase.idl"

Nit: I believe we normally put a trailing comma after the last value.
Nit: For all the dots that are literal dots (like right before the file extension) you should escape. For example `\.idl` and `\.js`.
Nit: I think all of these ending in ".*" are unnecessary, but I do see some existing examples so feel free to keep.
Comment 8 Devin Rousso 2017-10-27 18:08:16 PDT
Created attachment 325227 [details]
Patch
Comment 9 Build Bot 2017-10-27 18:09:45 PDT
Attachment 325227 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/watchlist:0:  In section "CC_RULES", the following definitions are not used and should be removed: WebRTC  [watchlist/general] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 WebKit Commit Bot 2017-10-27 18:39:16 PDT
Comment on attachment 325227 [details]
Patch

Clearing flags on attachment: 325227

Committed r224140: <https://trac.webkit.org/changeset/224140>
Comment 11 WebKit Commit Bot 2017-10-27 18:39:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2017-11-15 12:47:57 PST
<rdar://problem/35568157>