Bug 178951

Summary: [iOS] Unify Font::platformCharWidthInit() with macOS
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, dino, jonlee, mitz, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Archive of layout-test-results from ews124 for ios-simulator-wk2
none
Patch
none
Patch none

Myles C. Maxfield
Reported 2017-10-27 12:58:55 PDT
[iOS] Unify Font::platformCharWidthInit() with macOS
Attachments
WIP (1.95 KB, patch)
2017-10-27 13:00 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (1.05 MB, application/zip)
2017-10-27 14:21 PDT, Build Bot 		no flags
Details
Patch (30.05 KB, patch)
2017-10-27 15:42 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (30.09 KB, patch)
2017-10-27 15:42 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2017-10-27 13:00:17 PDT
Created attachment 325187 [details] WIP
Myles C. Maxfield
Comment 2 2017-10-27 13:01:05 PDT
<rdar://problem/7848198>
Build Bot
Comment 3 2017-10-27 13:02:02 PDT
Attachment 325187 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:12: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 4 2017-10-27 14:21:48 PDT
Comment on attachment 325187 [details] WIP Attachment 325187 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5014482 New failing tests: fast/forms/text-control-intrinsic-widths.html fast/forms/search-styled.html fast/forms/textarea-width.html
Build Bot
Comment 5 2017-10-27 14:21:49 PDT
Created attachment 325198 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Myles C. Maxfield
Comment 6 2017-10-27 15:42:11 PDT
Created attachment 325209 [details] Patch
Myles C. Maxfield
Comment 7 2017-10-27 15:42:53 PDT
Created attachment 325210 [details] Patch
WebKit Commit Bot
Comment 8 2017-10-28 19:45:31 PDT
Comment on attachment 325210 [details] Patch Clearing flags on attachment: 325210 Committed r224155: <https://trac.webkit.org/changeset/224155>
WebKit Commit Bot
Comment 9 2017-10-28 19:45:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.