| Summary: | [JSC] Tweak ES6 generator function to allow inlining | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | buildbot, fpizlo, jfbastien, joepeck, keith_miller, mark.lam, msaboff, sbarati, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Yusuke Suzuki
2017-10-27 06:02:25 PDT
Created attachment 325155 [details]
Patch
Created attachment 325157 [details]
Patch
Comment on attachment 325157 [details]
Patch
Ugh, this is stupid that we need to do this... We really need to fix our inlining rules...
Comment on attachment 325157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325157&action=review > Source/JavaScriptCore/ChangeLog:15 > + generator.es6 269.6030+-13.2435 ^ 148.8840+-6.7614 ^ definitely 1.8108x faster Wow! > Source/JavaScriptCore/builtins/GeneratorPrototype.js:70 > + if (typeof state !== 'number') Style: I think we try to always use double quoted strings in builtins for simple strings like "number" here. > Source/JavaScriptCore/builtins/GeneratorPrototype.js:84 > + if (typeof state !== 'number') Style: I think we try to always use double quoted strings in builtins for simple strings like "number" here. (In reply to Keith Miller from comment #3) > Comment on attachment 325157 [details] > Patch > > Ugh, this is stupid that we need to do this... We really need to fix our > inlining rules... Yeah, seriously ... Comment on attachment 325157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325157&action=review Yeah. In the meantime, I'll optimize it in this way. It's worth doing since these functions are builtin functions, and it is tightly coupled with JSC implementaiton. >> Source/JavaScriptCore/builtins/GeneratorPrototype.js:70 >> + if (typeof state !== 'number') > > Style: I think we try to always use double quoted strings in builtins for simple strings like "number" here. Fixed. >> Source/JavaScriptCore/builtins/GeneratorPrototype.js:84 >> + if (typeof state !== 'number') > > Style: I think we try to always use double quoted strings in builtins for simple strings like "number" here. Fixed. Committed r224141: <https://trac.webkit.org/changeset/224141> |