Bug 178935

Summary: [JSC] Tweak ES6 generator function to allow inlining
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, fpizlo, jfbastien, joepeck, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2017-10-27 06:02:25 PDT
[JSC] Tweak ES6 generator function to allow inlining
Attachments
Patch (5.20 KB, patch)
2017-10-27 06:08 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (4.57 KB, patch)
2017-10-27 06:16 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-10-27 06:08:15 PDT
Created attachment 325155 [details] Patch
Yusuke Suzuki
Comment 2 2017-10-27 06:16:38 PDT
Created attachment 325157 [details] Patch
Keith Miller
Comment 3 2017-10-27 10:45:52 PDT
Comment on attachment 325157 [details] Patch Ugh, this is stupid that we need to do this... We really need to fix our inlining rules...
Joseph Pecoraro
Comment 4 2017-10-27 11:10:28 PDT
Comment on attachment 325157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325157&action=review > Source/JavaScriptCore/ChangeLog:15 > + generator.es6 269.6030+-13.2435 ^ 148.8840+-6.7614 ^ definitely 1.8108x faster Wow! > Source/JavaScriptCore/builtins/GeneratorPrototype.js:70 > + if (typeof state !== 'number') Style: I think we try to always use double quoted strings in builtins for simple strings like "number" here. > Source/JavaScriptCore/builtins/GeneratorPrototype.js:84 > + if (typeof state !== 'number') Style: I think we try to always use double quoted strings in builtins for simple strings like "number" here.
Saam Barati
Comment 5 2017-10-27 11:32:30 PDT
(In reply to Keith Miller from comment #3) > Comment on attachment 325157 [details] > Patch > > Ugh, this is stupid that we need to do this... We really need to fix our > inlining rules... Yeah, seriously ...
Yusuke Suzuki
Comment 6 2017-10-27 18:46:11 PDT
Comment on attachment 325157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325157&action=review Yeah. In the meantime, I'll optimize it in this way. It's worth doing since these functions are builtin functions, and it is tightly coupled with JSC implementaiton. >> Source/JavaScriptCore/builtins/GeneratorPrototype.js:70 >> + if (typeof state !== 'number') > > Style: I think we try to always use double quoted strings in builtins for simple strings like "number" here. Fixed. >> Source/JavaScriptCore/builtins/GeneratorPrototype.js:84 >> + if (typeof state !== 'number') > > Style: I think we try to always use double quoted strings in builtins for simple strings like "number" here. Fixed.
Yusuke Suzuki
Comment 7 2017-10-27 18:49:06 PDT
Committed r224141: <https://trac.webkit.org/changeset/224141>
Radar WebKit Bug Importer
Comment 8 2017-11-15 12:36:13 PST
<rdar://problem/35567856>
Note You need to log in before you can comment on or make changes to this bug.