Bug 178932

Summary: [Web Animations] Implement the play() and pause() methods on Animation
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dino, eric.carlson, esprehn+autocc, ews-watchlist, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=122912
https://bugs.webkit.org/show_bug.cgi?id=179287
Attachments:
Description Flags
Patch eric.carlson: review+

Antoine Quint
Reported 2017-10-27 03:19:45 PDT
The Animation interface exposes a pause() method to control the animation's playback state.
Attachments
Patch (29.64 KB, patch)
2017-12-13 15:02 PST, Antoine Quint 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-10-31 06:40:23 PDT
<rdar://problem/35271069>
Antoine Quint
Comment 2 2017-12-13 14:49:47 PST
*** Bug 180401 has been marked as a duplicate of this bug. ***
Antoine Quint
Comment 3 2017-12-13 15:02:05 PST
Created attachment 329264 [details] Patch
EWS Watchlist
Comment 4 2017-12-13 15:03:59 PST
Attachment 329264 [details] did not pass style-queue: ERROR: Source/WebCore/animation/WebAnimation.h:103: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Carlson
Comment 5 2017-12-14 08:45:11 PST
Comment on attachment 329264 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329264&action=review > Source/WebCore/ChangeLog:15 > + Note that the play() method exposes an auto-rewing flag which we always set to true, but other specs, Nit: "auto-rewing" ->"auto-rewinding"
Antoine Quint
Comment 6 2017-12-14 09:39:48 PST
Committed r225909: <https://trac.webkit.org/changeset/225909>
Note You need to log in before you can comment on or make changes to this bug.