Bug 178918

Summary: [WPE] Build gst-plugins-base without pango support
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WPE WebKitAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, commit-queue, mcatanzaro, webkit-bug-importer
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
See Also: https://bugs.webkit.org/show_bug.cgi?id=178896
https://bugs.webkit.org/show_bug.cgi?id=179171
Attachments:
Description Flags
Patch
none
Patch none

Description Michael Catanzaro 2017-10-26 18:33:00 PDT 
When trying to run dyz inside our jhbuild environment, I see the following error:

(gst-plugin-scanner:16711): GStreamer-WARNING **: Failed to load plugin '/home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesWPE/Root/lib/gstreamer-1.0/libgstpango.so': /lib64/libpango-1.0.so.0: undefined symbol: g_log_structured

The problem is that pango is missing from our jhbuild environment. The modulesets will never work reliably if we have system libraries in the middle of our dependency graph, since they will sometimes depend on newer versions of libraries than we have inside the jhbuild.
Comment 1 Michael Catanzaro 2017-10-26 18:48:03 PDT 
Specifically, in this case, our glib is so old that it does not contain the structured logging support required by my system copy of pango.
Comment 2 Michael Catanzaro 2017-10-26 18:51:54 PDT 
Created attachment 325096 [details]
Patch
Comment 3 Carlos Garcia Campos 2017-10-27 00:07:11 PDT 
I don't think we should build pango. We could either bump the glib version, or build gst without pango.
Comment 4 Michael Catanzaro 2017-10-27 08:24:06 PDT 
(In reply to Carlos Garcia Campos from comment #3)
> I don't think we should build pango. We could either bump the glib version,

That's not good enough, it will break again in the future. The jhbuild environment has to be complete or it won't be reliable.

> or build gst without pango.

If that's possible, then this we could do. Let me check. (Anyway, I have absolutely no clue why GStreamer could possibly depend on pango.)
Comment 5 Michael Catanzaro 2017-10-27 09:57:46 PDT 
(In reply to Michael Catanzaro from comment #4)
> If that's possible, then this we could do. Let me check. (Anyway, I have
> absolutely no clue why GStreamer could possibly depend on pango.)

This works
Comment 6 Michael Catanzaro 2017-10-27 09:59:18 PDT 
Created attachment 325169 [details]
Patch
Comment 7 WebKit Commit Bot 2017-10-28 10:18:49 PDT 
Comment on attachment 325169 [details]
Patch

Clearing flags on attachment: 325169

Committed r224151: <https://trac.webkit.org/changeset/224151>
Comment 8 WebKit Commit Bot 2017-10-28 10:18:51 PDT 
All reviewed patches have been landed.  Closing bug.