Bug 178886

Summary:

Audit init*Event() method to make sure they reset internal data members

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, darin, dbates, esprehn+autocc, kangil.han, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=178670

Attachments:

Description	Flags
Patch	none

Chris Dumez

Reported 2017-10-26 14:35:29 PDT

Audit init*Event() method to make sure they reset internal data members.

Attachments
Patch (6.61 KB, patch) 2017-10-26 14:36 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-10-26 14:36:35 PDT

Created attachment 325055 [details] Patch

Chris Dumez

Comment 2 2017-10-27 09:50:15 PDT

Comment on attachment 325055 [details] Patch r224115

Darin Adler

Comment 3 2017-10-27 11:00:18 PDT

Comment on attachment 325055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325055&action=review > Source/WebCore/dom/MouseRelatedEvent.h:58 > + void setIsSimulated(bool value) { m_isSimulated = value; } protected instead?

Darin Adler

Comment 4 2017-10-27 11:00:44 PDT

If there was any effect of these changes, it would be nice to cover the effect in tests. Of course, the effects might be subtle so it might be hard to write tests.

Darin Adler

Comment 5 2017-10-28 17:48:34 PDT

Comment on attachment 325055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325055&action=review > Source/WebCore/dom/Event.cpp:93 > + m_underlyingEvent = nullptr; This doesn’t cover everything. A website could call initEvent on, say, a MouseEvent, and we might want it to reset a data member such as MouseEvent::m_dataTransfer. I am not sure what we should do about this.

Note You need to log in before you can comment on or make changes to this bug.