Bug 178854

Summary: [GTK][WPE] install-dependencies can't find libapache2-mod-php7.0 on Ubuntu 17.10
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: WebKitGTKAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, buildbot, commit-queue, glenn, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Fujii Hironori 2017-10-26 03:11:12 PDT
>  $ ./Tools/gtk/install-dependencies
> Reading package lists... Done
> Building dependency tree       
> Reading state information... Done
> Package libapache2-mod-php7.0 is not available, but is referred to by another package.
> This may mean that the package is missing, has been obsoleted, or
> is only available from another source
> 
> E: Package 'libapache2-mod-php7.0' has no installation candidate

./Tools/wpe/install-dependencies also fails.

Ubuntu 17.10 has following packages.

> libapache2-mod-php - server-side, HTML-embedded scripting language (Apache 2 module) (default)
> libapache2-mod-php7.1 - server-side, HTML-embedded scripting language (Apache 2 module)
Comment 1 Fujii Hironori 2017-10-26 03:19:16 PDT
Created attachment 324980 [details]
Patch
Comment 2 Michael Catanzaro 2017-10-26 05:01:24 PDT
Comment on attachment 324980 [details]
Patch

Do we still need to manually specify libapache2-mod-php5?
Comment 3 Fujii Hironori 2017-10-26 19:28:12 PDT
Good point. It can be removed.

libapache2-mod-php is required only for testing.
<https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy> doesn't matter in this case.
We no longer need to support Debian 8 (jessie).

I can remove LayoutTests/http/conf/debian-httpd-2.4.conf which refers php5.
Comment 4 Fujii Hironori 2017-10-26 19:58:24 PDT
Created attachment 325103 [details]
Patch
Comment 5 Michael Catanzaro 2017-10-26 20:08:58 PDT
Comment on attachment 325103 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325103&action=review

> LayoutTests/http/conf/debian-httpd-2.4-php7.0.conf:30
> +LoadModule php7_module          modules/libphp7.0.so

All for this one line difference... sigh.

Anyway, all the EWS are green, so let's land it and see if anything breaks.
Comment 6 WebKit Commit Bot 2017-10-26 21:04:21 PDT
Comment on attachment 325103 [details]
Patch

Clearing flags on attachment: 325103

Committed r224084: <https://trac.webkit.org/changeset/224084>
Comment 7 WebKit Commit Bot 2017-10-26 21:04:23 PDT
All reviewed patches have been landed.  Closing bug.