Summary: | [GTK][WPE] install-dependencies can't find libapache2-mod-php7.0 on Ubuntu 17.10 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
Component: | WebKitGTK | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bugs-noreply, buildbot, commit-queue, glenn, mcatanzaro | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Fujii Hironori
2017-10-26 03:11:12 PDT
Created attachment 324980 [details]
Patch
Comment on attachment 324980 [details]
Patch
Do we still need to manually specify libapache2-mod-php5?
Good point. It can be removed. libapache2-mod-php is required only for testing. <https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy> doesn't matter in this case. We no longer need to support Debian 8 (jessie). I can remove LayoutTests/http/conf/debian-httpd-2.4.conf which refers php5. Created attachment 325103 [details]
Patch
Comment on attachment 325103 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325103&action=review > LayoutTests/http/conf/debian-httpd-2.4-php7.0.conf:30 > +LoadModule php7_module modules/libphp7.0.so All for this one line difference... sigh. Anyway, all the EWS are green, so let's land it and see if anything breaks. Comment on attachment 325103 [details] Patch Clearing flags on attachment: 325103 Committed r224084: <https://trac.webkit.org/changeset/224084> All reviewed patches have been landed. Closing bug. |