Bug 178854 – [GTK][WPE] install-dependencies can't find libapache2-mod-php7.0 on Ubuntu 17.10

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Fujii Hironori]

>  $ ./Tools/gtk/install-dependencies
> Reading package lists... Done
> Building dependency tree       
> Reading state information... Done
> Package libapache2-mod-php7.0 is not available, but is referred to by another package.
> This may mean that the package is missing, has been obsoleted, or
> is only available from another source
> 
> E: Package 'libapache2-mod-php7.0' has no installation candidate

./Tools/wpe/install-dependencies also fails.

Ubuntu 17.10 has following packages.

> libapache2-mod-php - server-side, HTML-embedded scripting language (Apache 2 module) (default)
> libapache2-mod-php7.1 - server-side, HTML-embedded scripting language (Apache 2 module)

[Fujii Hironori]

Created attachment 324980 [details]
Patch

[Michael Catanzaro]

Comment on attachment 324980 [details]
Patch

Do we still need to manually specify libapache2-mod-php5?

[Fujii Hironori]

Good point. It can be removed.

libapache2-mod-php is required only for testing.
<https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy> doesn't matter in this case.
We no longer need to support Debian 8 (jessie).

I can remove LayoutTests/http/conf/debian-httpd-2.4.conf which refers php5.

[Fujii Hironori]

Created attachment 325103 [details]
Patch

[Michael Catanzaro]

Comment on attachment 325103 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325103&action=review

> LayoutTests/http/conf/debian-httpd-2.4-php7.0.conf:30
> +LoadModule php7_module          modules/libphp7.0.so

All for this one line difference... sigh.

Anyway, all the EWS are green, so let's land it and see if anything breaks.

[WebKit Commit Bot]

Comment on attachment 325103 [details]
Patch

Clearing flags on attachment: 325103

Committed r224084: <https://trac.webkit.org/changeset/224084>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.