Bug 178840

Summary: Move WKWebViewConfiguration validation to WKWebView construction
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch thorton: review+

Description Alex Christensen 2017-10-25 18:12:22 PDT
Move WKWebViewConfiguration validation to WKWebView construction
Comment 1 Alex Christensen 2017-10-25 18:15:38 PDT
Created attachment 324935 [details]
Patch
Comment 2 Anders Carlsson 2017-10-26 08:03:38 PDT
Comment on attachment 324935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324935&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:484
> +    if (![_configuration processPool])
> +        [NSException raise:NSInvalidArgumentException format:@"configuration.processPool is nil"];
> +    
> +    if (![_configuration preferences])
> +        [NSException raise:NSInvalidArgumentException format:@"configuration.preferences is nil"];
> +    
> +    if (![_configuration userContentController])
> +        [NSException raise:NSInvalidArgumentException format:@"configuration.userContentController is nil"];
> +    
> +    if (![_configuration websiteDataStore])
> +        [NSException raise:NSInvalidArgumentException format:@"configuration.websiteDataStore is nil"];
> +    
> +    if (![_configuration _visitedLinkStore])
> +        [NSException raise:NSInvalidArgumentException format:@"configuration._visitedLinkStore is nil"];
> +    
> +#if PLATFORM(IOS)
> +    if (![_configuration _contentProviderRegistry])
> +        [NSException raise:NSInvalidArgumentException format:@"configuration._contentProviderRegistry is nil"];
> +#endif

I still think you should put this in a separate method.
Comment 3 Alex Christensen 2017-10-26 12:00:34 PDT
Created attachment 325037 [details]
Patch
Comment 4 Alex Christensen 2017-10-26 12:33:38 PDT
Created attachment 325041 [details]
Patch
Comment 5 Tim Horton 2017-10-26 16:38:46 PDT
Comment on attachment 325041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325041&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:450
> +- (void)_validateConfiguration:(WKWebViewConfiguration *)configuration

maybe this can just be a free function?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:52
> +        [configuration setProcessPool: nil];

No spaces after colons!
Comment 6 Alex Christensen 2017-10-26 17:00:13 PDT
http://trac.webkit.org/r224071
Comment 7 Radar WebKit Bug Importer 2017-11-15 12:43:59 PST
<rdar://problem/35568043>