Bug 178838

Summary: Implement seek tolerance methods in WebAVPlayerController.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing none

Jeremy Jones
Reported 2017-10-25 16:52:48 PDT
Implement seek tolerance methods in WebAVPlayerController.
Attachments
Patch (15.12 KB, patch)
2017-10-25 16:59 PDT, Jeremy Jones 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (14.63 KB, patch)
2017-10-26 16:10 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2017-10-25 16:54:24 PDT
rdar://problem/33781777
Jeremy Jones
Comment 2 2017-10-25 16:59:35 PDT
Created attachment 324925 [details] Patch
Eric Carlson
Comment 3 2017-10-25 17:18:50 PDT
Comment on attachment 324925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324925&action=review > Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:143 > + void seekToTime(double, double, double) override; Nit : some of the changes in this patch won’t be necessary if you give the new parameters default values of 0.
Jeremy Jones
Comment 4 2017-10-26 16:10:25 PDT
Created attachment 325074 [details] Patch for landing
WebKit Commit Bot
Comment 5 2017-10-26 23:06:42 PDT
Comment on attachment 325074 [details] Patch for landing Clearing flags on attachment: 325074 Committed r224085: <https://trac.webkit.org/changeset/224085>
Note You need to log in before you can comment on or make changes to this bug.