Bug 178837

Summary: Web Inspector: Styles Redesign: Make "Style Attribute" text darker and non-focusable
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Current UI
none
Patch
none
[Image] With patch applied none

Nikita Vasilyev
Reported 2017-10-25 16:36:24 PDT
Created attachment 324920 [details] [Image] Current UI "Style Attribute" is currently light gray and could be confused for a disabled section. "Style Attribute" is not editable and should not be focusable.
Attachments
[Image] Current UI (27.01 KB, image/png)
2017-10-25 16:36 PDT, Nikita Vasilyev 		no flags
Details
Patch (2.72 KB, patch)
2017-10-25 16:40 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Image] With patch applied (33.96 KB, image/png)
2017-10-25 16:41 PDT, Nikita Vasilyev 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2017-10-25 16:40:22 PDT
Created attachment 324921 [details] Patch
Nikita Vasilyev
Comment 2 2017-10-25 16:41:59 PDT
Created attachment 324923 [details] [Image] With patch applied
Blaze Burg
Comment 3 2017-10-26 16:27:04 PDT
Comment on attachment 324921 [details] Patch rs=me
WebKit Commit Bot
Comment 4 2017-10-26 16:32:09 PDT
Comment on attachment 324921 [details] Patch Clearing flags on attachment: 324921 Committed r224064: <https://trac.webkit.org/changeset/224064>
WebKit Commit Bot
Comment 5 2017-10-26 16:32:10 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-11-15 12:44:10 PST
<rdar://problem/35568051>
Note You need to log in before you can comment on or make changes to this bug.