Summary: | LayoutTest http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html is a flaky failure | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||
Component: | New Bugs | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, cdumez, commit-queue, rniwa, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=178422 | ||||||||
Attachments: |
|
Description
Ryan Haddad
2017-10-25 14:04:57 PDT
Created attachment 324950 [details]
Removes the superflous call to finishJSTest
Notice that the flakiness dashboard shows failures whenever the test took 3s. Comment on attachment 324950 [details]
Removes the superflous call to finishJSTest
rs=me
Comment on attachment 324950 [details] Removes the superflous call to finishJSTest Clearing flags on attachment: 324950 Committed r224010: <https://trac.webkit.org/changeset/224010> All reviewed patches have been landed. Closing bug. This wasn't the root cause of the problem, as finishJSTest couldn't cause the unhandled promise rejection message. +CONSOLE MESSAGE: line 30: Unhandled Promise Rejection: TypeError: null is not an object (evaluating 'frame.contentDocument.body.innerHTML') Removing the forced completion after 3 seconds has turned the test into a flaky timeout, hitting the same promise rejection on line 30. (In reply to Alexey Proskuryakov from comment #7) > This wasn't the root cause of the problem, as finishJSTest couldn't cause > the unhandled promise rejection message. > > +CONSOLE MESSAGE: line 30: Unhandled Promise Rejection: TypeError: null is > not an object (evaluating 'frame.contentDocument.body.innerHTML') > > Removing the forced completion after 3 seconds has turned the test into a > flaky timeout, hitting the same promise rejection on line 30. Oh, I missed that. We probably need to wait for the frame's content document to become available. Created attachment 325044 [details]
Another fix
Committed r224052: <https://trac.webkit.org/changeset/224052> Looks like the test stopped flaking! |