Bug 178819

Summary:

[MSE][GStreamer] Fix hang on clearing/destroying AppendPipeline

Product:

WebKit

Reporter:

Enrique Ocaña <eocanha>

Component:

Media

Assignee:

Enrique Ocaña <eocanha>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Enrique Ocaña 2017-10-25 11:40:24 PDT

A deadlock may occur when UI thread tries to clear pipeline in AppendPipeline::clearPlayerPrivate() while parser thread tries to change pipeline state to pause holding the stream lock in AppendPipeline::connectDemuxerSrcPadToAppsinkFromAnyThread().

This issue has been fixed downstream in https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/392

Comment 1 Enrique Ocaña 2017-10-25 11:45:43 PDT

Created attachment 324859 [details]
Patch

Comment 2 WebKit Commit Bot 2017-10-26 03:31:42 PDT

Comment on attachment 324859 [details]
Patch

Clearing flags on attachment: 324859

Committed r224012: <https://trac.webkit.org/changeset/224012>

Comment 3 WebKit Commit Bot 2017-10-26 03:31:44 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2017-11-15 12:45:25 PST

<rdar://problem/35568087>