| Summary: | Web Inspector: Canvas Tab: no path components shown in recording content view after selecting a recording via View Recordings... dropdown | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Blaze Burg <bburg> | ||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=178797 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 173807, 175485 | ||||||||
| Attachments: |
|
||||||||
This only seems to occur for the first recording. If there are >1 recordings, the other ones don't have this problem. Created attachment 325133 [details]
Patch
Comment on attachment 325133 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325133&action=review r=me > Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js:-98 > - this.addRepresentedObjectToNewChildQueue(event.data.item); I'm not familiar with the function, what was the intent behind this.addRepresentedObjectToNewChildQueue? Comment on attachment 325133 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325133&action=review >> Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js:-98 >> - this.addRepresentedObjectToNewChildQueue(event.data.item); > > I'm not familiar with the function, what was the intent behind this.addRepresentedObjectToNewChildQueue? `addRepresentedObjectToNewChildQueue` is implemented on FolderizedTreeElement.js:113. The comment in the function says this: // This queue reduces flashing as resources load and change folders when their type becomes known. It keeps a queue of items to add and runs through it once per frame, basically batching the add/remove operations. For things that don't "load" per se, however, it is probably unnecessary. Canvases/ShaderPrograms don't ever change type, so we don't really need to worry about that. Comment on attachment 325133 [details] Patch Clearing flags on attachment: 325133 Committed r224200: <https://trac.webkit.org/changeset/224200> All reviewed patches have been landed. Closing bug. |
Created attachment 324842 [details] Screenshot STR: 1. Visit acko.net 2. Create a recording 3. Go back via arrow in jump bar 4. Select recording via View Recordings... => No path components shown at all