Bug 178799 – Web Inspector: Canvas Tab: no way to see backtrace of where a canvas context was created

• Component: Web Inspector
• Status: RESOLVED FIXED

[Blaze Burg]

Acko.net has several canvases and I have no way to tell which one was made where. There should be a way to see this, perhaps in an "Initiator" field in the details sidebar.

[Radar WebKit Bug Importer]

<rdar://problem/35175805>

[Devin Rousso]

Created attachment 325138 [details]
Patch

[Devin Rousso]

Created attachment 325139 [details]
[Image] After Patch is applied

[Blaze Burg]

Comment on attachment 325138 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325138&action=review

r=me

> Source/WebCore/inspector/InspectorCanvas.cpp:194
> +Ref<Inspector::Protocol::Canvas::Canvas> InspectorCanvas::buildObjectForCanvas(InstrumentingAgents& instrumentingAgents, bool captureBacktrace)

This sort of implicitly assumes this method is called underneath canvasAdded and equivalent JS code that creates the context. Perhaps you should write this into the description of the protocol parameter so that the semantics are more clear. For example, "Backtrace that was captured when this canvas context is created".

> Source/WebCore/inspector/InspectorCanvas.cpp:261
> +    if (captureBacktrace) {

It would be cool to extract common stack walking code. It could take a lambda(ScriptCallFrame&) to perform the extraction (swizzled index or buildInspectorObject()). Please re-EWS if you do that.

> Source/WebCore/inspector/InspectorCanvasAgent.cpp:395
> +        m_frontendDispatcher->canvasAdded(inspectorCanvas->buildObjectForCanvas(m_instrumentingAgents, true));

I would remove the default parameter value and add 'false' to the other call site just so it's explicit. (If we called this in dozens of places, my opinion would be different.) Can you extract 'true' or 'false' into a local variable with a better name?

[Devin Rousso]

Created attachment 325216 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 325216 [details]
Patch

Clearing flags on attachment: 325216

Committed r224142: <https://trac.webkit.org/changeset/224142>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.