Summary: | Web Inspector: Styles Redesign: typing colon in property name should advance to value field | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, nvasilyev, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
BJ Burg
2017-10-25 09:02:24 PDT
Created attachment 326953 [details]
Patch
Typing colon ANYWHERE in the property name advances to value field. This matches Chrome and Firefox.
I could remove text on the right side of colon and prepend it to property value. I wasn't sure if it's useful, so I didn't do it in this patch.
Comment on attachment 326953 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326953&action=review r=me > Source/WebInspectorUI/ChangeLog:29 > + (WI.SpreadsheetTextField): NIT: this should be at the beginning of the WI.SpreadsheetTextField list. This happens to me every once in a while for some reason ¯\_(ツ)_/¯ > Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:177 > + this._nameElement.addEventListener("beforeinput", (event) => { Since you are adding the event listener to the element itself, I'd reorder these. this._nameElement.tabIndex = 0; this._nameElement.addEventListener("beforeinput", this._handleNameBeforeinput.bind(this)); this._nameTextField = new WI.SpreadsheetTextField(this, this._nameElement, this._nameCompletionDataProvider.bind(this)); I'd also suggest moving the callback to be a member function. I typically try to only use inline event listeners for extremely small (effectively one line) callbacks, or contextmenu stuff. Created attachment 327023 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 327023 [details]:
The commit-queue is continuing to process your patch.
Comment on attachment 327023 [details] Patch Clearing flags on attachment: 327023 Committed r224906: <https://trac.webkit.org/changeset/224906> All reviewed patches have been landed. Closing bug. |