Bug 178793

Summary: [GTK] Test gardening
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: aperez, buildbot, commit-queue, dbates, lforschler, mcatanzaro, mkwst, Ms2ger
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+, commit-queue: commit-queue-

Alicia Boya García
Reported 2017-10-25 07:58:21 PDT
Reported and updated expectations: +webkit.org/b/178785 perf/object-keys.html [ Pass Failure ] +webkit.org/b/178777 fast/css-generated-content/details-summary-before-after.html [ Failure ] +webkit.org/b/178780 http/tests/fileapi/xhr-send-form-data-filename-escaping.html [ Failure ] +webkit.org/b/178781 http/tests/inspector/network/har/har-page.html [ Failure ] +webkit.org/b/178784 inspector/console/webcore-logging.html [ Failure ] +webkit.org/b/178787 svg/batik/text/smallFonts.svg [ Failure ] -webkit.org/b/157731 fast/events/touch/touch-inside-iframe-scrolled.html [ Timeout Pass ] +webkit.org/b/157731 fast/events/touch/touch-inside-iframe-scrolled.html [ Timeout Pass Failure ] +webkit.org/b/178791 editing/selection/drag-to-contenteditable-iframe.html [ Timeout ] +webkit.org/b/178792 fast/events/touch/touch-inside-iframe.html [ Timeout ] Updated expected outputs: LayoutTests/platform/gtk/http/tests/security/contentSecurityPolicy/1.1/module-scriptnonce-redirect-expected.txt LayoutTests/platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt
Attachments
Patch (17.49 KB, patch)
2017-10-25 08:06 PDT, Alicia Boya García
mcatanzaro: review+
commit-queue: commit-queue-
Alicia Boya García
Comment 1 2017-10-25 08:06:33 PDT
Michael Catanzaro
Comment 2 2017-11-02 05:32:39 PDT
So was it ever committed? I guess not?
WebKit Commit Bot
Comment 3 2017-11-02 05:34:17 PDT
Comment on attachment 324821 [details] Patch Rejecting attachment 324821 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 324821, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -------- No file to patch. Skipping patch. 1 out of 1 hunk ignored patching file LayoutTests/platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt patching file LayoutTests/platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Michael Catanzaro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/5075432
Adrian Perez
Comment 4 2018-04-26 03:27:43 PDT
(In reply to Michael Catanzaro from comment #2) > So was it ever committed? I guess not? No, this has not been committed. Right now it needs a rebase. Alicia, could you please update this patch? Thanks in advance!
Alicia Boya García
Comment 5 2018-05-14 03:01:24 PDT
(In reply to Adrian Perez from comment #4) > (In reply to Michael Catanzaro from comment #2) > > So was it ever committed? I guess not? > > No, this has not been committed. Right now it needs a rebase. > Alicia, could you please update this patch? Thanks in advance! I've been on holidays for these couple of weeks. Is this still relevant?
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 6 2018-08-06 06:25:47 PDT
Let's assume not.
Alicia Boya García
Comment 7 2018-08-21 02:28:56 PDT
> (In reply to Adrian Perez from comment #4) > I've been on holidays for these couple of weeks. Is this still relevant? Not anymore, this is now an almost one year old gardening patch.
Note You need to log in before you can comment on or make changes to this bug.