Bug 178786

Summary:

Remove unnecessary whitespace invalidation logic from RenderTreeUpdater

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, commit-queue, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	none
patch	none
patch	buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
patch	buildbot: commit-queue-
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
patch	none
Archive of layout-test-results from ews102 for mac-elcapitan	none

Antti Koivisto

Reported 2017-10-25 05:05:44 PDT

RenderTreeUpdater::invalidateWhitespaceOnlyTextSiblingsAfterAttachIfNeeded is a pretty complex function for figuring out if some whitespace-only text node might need to have its rendering status recomputed. However actually computing if a text renderer is needed is not expensive. We can simply do it for all whitespace nodes.

Attachments
patch (4.38 KB, patch) 2017-10-25 05:06 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (15.70 KB, patch) 2017-10-25 05:47 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (25.88 KB, patch) 2017-10-25 06:29 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (30.08 KB, patch) 2017-10-25 07:15 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (1.17 MB, application/zip) 2017-10-25 08:14 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (2.06 MB, application/zip) 2017-10-25 08:18 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.23 MB, application/zip) 2017-10-25 08:40 PDT, Build Bot	no flags	Details
patch (40.04 KB, patch) 2017-10-26 02:41 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.06 MB, application/zip) 2017-10-26 05:28 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.42 MB, application/zip) 2017-10-26 05:51 PDT, Build Bot	no flags	Details
patch (8.60 KB, patch) 2017-10-26 09:17 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (994.52 KB, application/zip) 2017-10-26 10:13 PDT, Build Bot	no flags	Details
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2017-10-25 05:06:11 PDT

Created attachment 324809 [details] patch

Antti Koivisto

Comment 2 2017-10-25 05:47:24 PDT

Created attachment 324812 [details] patch

Antti Koivisto

Comment 3 2017-10-25 06:29:05 PDT

Created attachment 324815 [details] patch

Antti Koivisto

Comment 4 2017-10-25 07:15:24 PDT

Created attachment 324818 [details] patch

Build Bot

Comment 5 2017-10-25 08:14:46 PDT

Comment on attachment 324818 [details] patch Attachment 324818 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4983393 New failing tests: http/tests/cache/iframe-304-crash.html fast/events/content-changed-during-drop.html svg/custom/svg-fonts-in-html.html http/tests/security/xss-DENIED-script-inject-into-inactive-window.html

Build Bot

Comment 6 2017-10-25 08:14:47 PDT

Created attachment 324822 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-10-25 08:18:19 PDT

Comment on attachment 324818 [details] patch Attachment 324818 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4983361 New failing tests: http/tests/cache/iframe-304-crash.html imported/w3c/web-platform-tests/css/css-display-3/display-contents-state-change-001.html svg/custom/svg-fonts-in-html.html fast/events/content-changed-during-drop.html http/tests/security/xss-DENIED-script-inject-into-inactive-window.html

Build Bot

Comment 8 2017-10-25 08:18:21 PDT

Created attachment 324823 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2017-10-25 08:40:57 PDT

Comment on attachment 324818 [details] patch Attachment 324818 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4983425 New failing tests: http/tests/paymentrequest/payment-response-payerName-attribute.https.html http/tests/paymentrequest/payment-response-payerPhone-attribute.https.html transforms/3d/point-mapping/3d-point-mapping-2.html fast/frames/iframe-option-crash.xhtml http/tests/paymentrequest/payment-response-complete-method.https.html http/tests/paymentrequest/payment-response-payerEmail-attribute.https.html fast/dynamic/float-in-trailing-whitespace-after-last-line-break.html transforms/3d/point-mapping/3d-point-mapping-origins.html

Build Bot

Comment 10 2017-10-25 08:40:58 PDT

Created attachment 324825 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Antti Koivisto

Comment 11 2017-10-26 02:41:31 PDT

Created attachment 324978 [details] patch

Build Bot

Comment 12 2017-10-26 05:28:38 PDT

Comment on attachment 324978 [details] patch Attachment 324978 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4997297 New failing tests: http/tests/security/xss-DENIED-script-inject-into-inactive-window.html

Build Bot

Comment 13 2017-10-26 05:28:39 PDT

Created attachment 324994 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Build Bot

Comment 14 2017-10-26 05:51:40 PDT

Comment on attachment 324978 [details] patch Attachment 324978 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4997654 New failing tests: http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm svg/custom/getscreenctm-in-mixed-content.xhtml svg/custom/svg-fonts-in-html.html http/tests/security/xss-DENIED-script-inject-into-inactive-window.html

Build Bot

Comment 15 2017-10-26 05:51:41 PDT

Created attachment 324997 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 16 2017-10-26 09:17:33 PDT

Created attachment 325015 [details] patch

Build Bot

Comment 17 2017-10-26 10:13:19 PDT

Comment on attachment 325015 [details] patch Attachment 325015 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4999501 New failing tests: fast/xmlhttprequest/xmlhttprequest-access-self-as-blob.html

Build Bot

Comment 18 2017-10-26 10:13:21 PDT

Created attachment 325023 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

WebKit Commit Bot

Comment 19 2017-10-26 11:51:37 PDT

Comment on attachment 325015 [details] patch Clearing flags on attachment: 325015 Committed r224034: <https://trac.webkit.org/changeset/224034>

WebKit Commit Bot

Comment 20 2017-10-26 11:51:39 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 21 2017-11-15 12:47:14 PST

<rdar://problem/35568129>

Note You need to log in before you can comment on or make changes to this bug.