Summary: | Flakiness dashboard: Make GTK and WPE builds inherit expectations from WK2 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alicia Boya García <aboya> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, lforschler, mcatanzaro, webkit-bug-importer, zan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Alicia Boya García
2017-10-25 03:54:14 PDT
Turns out the flakiness dashboard is assuming GTK ports are WK1, therefore WK2 expectations are not taken into account. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showWrongExpectations=true&builder=GTK%20Linux%2064-bit%20Release%20(Tests) Look at the top: Expectations for GTK_LINUX_WK1-RELEASE This is the result of a logic in determineBuilderPlatform() that determines whether a platform is WK2 or WK1 based on its name: If it does not contain WK2, it assumes it's WK1. Created attachment 329132 [details]
Patch
Comment on attachment 329132 [details] Patch Clearing flags on attachment: 329132 Committed r225819: <https://trac.webkit.org/changeset/225819> All reviewed patches have been landed. Closing bug. The hosted version continues to run an old revision: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#builder=GTK%20Linux%2064-bit%20Release%20(Tests) Note it still says WK1. Who should I ping for fixing that? Try asking admin@webkit.org |