| Summary: | Web Inspector: preserve Recordings for each Canvas after closing the Canvas tab | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bburg, buildbot, commit-queue, inspector-bugzilla-changes, rniwa, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Bug Depends on: | 177606 | ||||||||||||||
| Bug Blocks: | 173807, 175485 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Devin Rousso
2017-10-24 18:25:40 PDT
Created attachment 324769 [details]
Patch
Comment on attachment 324769 [details] Patch Attachment 324769 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4978567 New failing tests: inspector/canvas/requestContent-webgl2.html inspector/canvas/resolveCanvasContext-webgl2.html inspector/canvas/recording-webgl-snapshots.html inspector/canvas/requestNode.html inspector/canvas/requestContent-2d.html inspector/canvas/requestShaderSource.html inspector/canvas/memory.html inspector/canvas/setShaderProgramDisabled.html inspector/canvas/resolveCanvasContext-2d.html inspector/canvas/recording-2d.html inspector/canvas/recording-webgl.html inspector/canvas/resolveCanvasContext-webgpu.html inspector/css/pseudo-element-matches.html inspector/canvas/resolveCanvasContext-webgl.html inspector/canvas/requestContent-webgl.html inspector/canvas/updateShader.html inspector/canvas/create-context-webgl.html Created attachment 324779 [details]
Archive of layout-test-results from ews100 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 324769 [details] Patch Attachment 324769 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4978630 New failing tests: inspector/canvas/requestContent-webgl2.html inspector/canvas/resolveCanvasContext-webgl2.html inspector/canvas/recording-webgl-snapshots.html inspector/canvas/requestNode.html inspector/canvas/requestContent-2d.html inspector/canvas/requestShaderSource.html inspector/canvas/memory.html inspector/canvas/setShaderProgramDisabled.html inspector/canvas/resolveCanvasContext-2d.html inspector/canvas/recording-2d.html inspector/canvas/recording-webgl.html inspector/canvas/resolveCanvasContext-webgpu.html inspector/css/pseudo-element-matches.html inspector/canvas/resolveCanvasContext-webgl.html inspector/canvas/requestContent-webgl.html inspector/canvas/updateShader.html inspector/canvas/create-context-webgl.html Created attachment 324780 [details]
Archive of layout-test-results from ews112 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 324793 [details]
Patch
Comment on attachment 324793 [details]
Patch
r=me
v.nice. is there anything we want to test here? It seems too straightforward really...
Created attachment 324798 [details]
Patch
Unreviewed addition: added assertions to existing test utility file that the recording is listed on the related canvas.
Comment on attachment 324798 [details] Patch Clearing flags on attachment: 324798 Committed r223952: <https://trac.webkit.org/changeset/223952> All reviewed patches have been landed. Closing bug. |