Bug 178748

Summary: Allow OjbC Weak References when building TestAPI
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, keith_miller, mark.lam, mitz, sbarati, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Updated Patch none

Description Michael Saboff 2017-10-24 14:02:34 PDT
TestAPI is built using manual reference counting.  Some version of the compiler will complain when building with default build flags.
Comment 1 Radar WebKit Bug Importer 2017-10-24 14:03:44 PDT
<rdar://problem/35158752>
Comment 2 Michael Saboff 2017-10-24 14:12:01 PDT
Created attachment 324718 [details]
Patch
Comment 3 WebKit Commit Bot 2017-10-24 14:31:05 PDT
Comment on attachment 324718 [details]
Patch

Clearing flags on attachment: 324718

Committed r223923: <https://trac.webkit.org/changeset/223923>
Comment 4 WebKit Commit Bot 2017-10-24 14:31:06 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 mitz 2017-10-24 14:55:40 PDT
Comment on attachment 324718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324718&action=review

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:10386
> +				CLANG_ENABLE_OBJC_WEAK = YES;

We shouldn’t specify build settings in the project file. This can probably go in ToolExecutable.xcconfig or if, for some reason, it can’t apply to all tools, in a new .xcconfig file.
Comment 6 Michael Saboff 2017-10-24 15:05:20 PDT
(In reply to mitz from comment #5)
> Comment on attachment 324718 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=324718&action=review
> 
> > Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:10386
> > +				CLANG_ENABLE_OBJC_WEAK = YES;
> 
> We shouldn’t specify build settings in the project file. This can probably
> go in ToolExecutable.xcconfig or if, for some reason, it can’t apply to all
> tools, in a new .xcconfig file.

Reopening this bug to move the build setting.
Comment 7 Michael Saboff 2017-10-24 15:21:59 PDT
Created attachment 324737 [details]
Updated Patch
Comment 8 WebKit Commit Bot 2017-10-24 15:59:54 PDT
Comment on attachment 324737 [details]
Updated Patch

Clearing flags on attachment: 324737

Committed r223937: <https://trac.webkit.org/changeset/223937>
Comment 9 WebKit Commit Bot 2017-10-24 15:59:56 PDT
All reviewed patches have been landed.  Closing bug.