Summary: | Allow OjbC Weak References when building TestAPI | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||||
Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | buildbot, commit-queue, keith_miller, mark.lam, mitz, saam, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Michael Saboff
2017-10-24 14:02:34 PDT
Created attachment 324718 [details]
Patch
Comment on attachment 324718 [details] Patch Clearing flags on attachment: 324718 Committed r223923: <https://trac.webkit.org/changeset/223923> All reviewed patches have been landed. Closing bug. Comment on attachment 324718 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324718&action=review > Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:10386 > + CLANG_ENABLE_OBJC_WEAK = YES; We shouldn’t specify build settings in the project file. This can probably go in ToolExecutable.xcconfig or if, for some reason, it can’t apply to all tools, in a new .xcconfig file. (In reply to mitz from comment #5) > Comment on attachment 324718 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=324718&action=review > > > Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:10386 > > + CLANG_ENABLE_OBJC_WEAK = YES; > > We shouldn’t specify build settings in the project file. This can probably > go in ToolExecutable.xcconfig or if, for some reason, it can’t apply to all > tools, in a new .xcconfig file. Reopening this bug to move the build setting. Created attachment 324737 [details]
Updated Patch
Comment on attachment 324737 [details] Updated Patch Clearing flags on attachment: 324737 Committed r223937: <https://trac.webkit.org/changeset/223937> All reviewed patches have been landed. Closing bug. |