Bug 178719 – [GTK] When using EGL, request an OpenGL core profile when possible

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Miguel Gomez]

When using GLX, we try to get an OpenGL 3.2 core profile when possible, and fall back to whatever is available if not. But we are not doing this with EGL, and we just use what EGL wants to give us. We need to implement the capability to request an OpenGL 3.2 core profile as well when possible with EGL as well.

From that I read, the required EGL API for this is available since EGL 1.5 or EGL 1.4 if the extension EGL_KHR_create_context is available.

[Miguel Gomez]

Created attachment 335924 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 335924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335924&action=review

> Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:379
> +        String versionString = String(reinterpret_cast<const char*>(eglQueryString(display, EGL_VERSION)));
> +        Vector<String> versionStringComponents;
> +        versionString.split(' ', versionStringComponents);
> +        Vector<String> versionDigits;
> +        versionStringComponents[0].split('.', versionDigits);
> +        uint version = versionDigits[0].toUInt() * 100 + versionDigits[1].toUInt() * 10;

I don't think we need to parse the version here again. We already have the version parsed when EGL is initialized in PlatformDisplay. I guess we could simply pass the PlatformDisplay here instead of the EGLDisplay and use PlatformDisplay::eglCheckVersion()

> Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:417
> +        contextAttributesInitialized = true;

We are doing this in all the cases inside the if, no? I think we can dot this once at the beginning.

[Miguel Gomez]

Created attachment 335926 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 335926 [details]
Patch

Clearing flags on attachment: 335926

Committed r229663: <https://trac.webkit.org/changeset/229663>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.