Bug 178708

Summary:

DocumentOrderedMap::add should release assert that tree scopes match

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

DOM

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, dbates, ddkilzer, esprehn+autocc, fpizlo, kangil.han, koivisto, rniwa, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Tighens the assertion	none
Tighens the assertion	none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2	none

Ryosuke Niwa

Reported 2017-10-23 21:19:47 PDT

DocumentOrderedMap::add should assert that the tree scope of the element matches that of the passed value instead of simply asserting that the element is in a tree scope.

Attachments
Tighens the assertion (4.55 KB, patch) 2017-10-23 21:26 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Tighens the assertion (4.67 KB, patch) 2017-10-23 21:27 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.17 MB, application/zip) 2017-10-23 22:19 PDT, Build Bot	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2017-10-23 21:26:03 PDT

Created attachment 324637 [details] Tighens the assertion

Ryosuke Niwa

Comment 2 2017-10-23 21:27:36 PDT

Created attachment 324638 [details] Tighens the assertion

Ryosuke Niwa

Comment 3 2017-10-23 21:28:16 PDT

<rdar://problem/35009035>

Build Bot

Comment 4 2017-10-23 21:30:33 PDT

Attachment 324638 [details] did not pass style-queue: ERROR: Source/WebCore/dom/DocumentOrderedMap.cpp:110: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 5 2017-10-23 22:19:31 PDT

Comment on attachment 324638 [details] Tighens the assertion Attachment 324638 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4966599 New failing tests: http/tests/appcache/decide-navigation-policy-after-delay.html

Build Bot

Comment 6 2017-10-23 22:19:33 PDT

Created attachment 324643 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Ryosuke Niwa

Comment 7 2017-10-23 22:30:47 PDT

I don't think http/tests/appcache/decide-navigation-policy-after-delay.html failure is related to this change since it only modifies the release assertions.

Ryosuke Niwa

Comment 8 2017-10-24 00:23:51 PDT

Comment on attachment 324638 [details] Tighens the assertion Oops, I meant to set cq+ on another patch.

WebKit Commit Bot

Comment 9 2017-10-24 01:54:46 PDT

Comment on attachment 324638 [details] Tighens the assertion Clearing flags on attachment: 324638 Committed r223886: <https://trac.webkit.org/changeset/223886>

WebKit Commit Bot

Comment 10 2017-10-24 01:54:48 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.