Bug 178708

Summary: DocumentOrderedMap::add should release assert that tree scopes match
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, dbates, ddkilzer, esprehn+autocc, fpizlo, kangil.han, koivisto, rniwa, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Tighens the assertion
none
Tighens the assertion
none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 none

Description Ryosuke Niwa 2017-10-23 21:19:47 PDT 
DocumentOrderedMap::add should assert that the tree scope of the element matches that of the passed value
instead of simply asserting that the element is in a tree scope.
Comment 1 Ryosuke Niwa 2017-10-23 21:26:03 PDT 
Created attachment 324637 [details]
Tighens the assertion
Comment 2 Ryosuke Niwa 2017-10-23 21:27:36 PDT 
Created attachment 324638 [details]
Tighens the assertion
Comment 3 Ryosuke Niwa 2017-10-23 21:28:16 PDT 
<rdar://problem/35009035>
Comment 4 Build Bot 2017-10-23 21:30:33 PDT 
Attachment 324638 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/DocumentOrderedMap.cpp:110:  Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION().  [security/assertion] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Build Bot 2017-10-23 22:19:31 PDT 
Comment on attachment 324638 [details]
Tighens the assertion

Attachment 324638 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4966599

New failing tests:
http/tests/appcache/decide-navigation-policy-after-delay.html
Comment 6 Build Bot 2017-10-23 22:19:33 PDT 
Created attachment 324643 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 7 Ryosuke Niwa 2017-10-23 22:30:47 PDT 
I don't think http/tests/appcache/decide-navigation-policy-after-delay.html failure is related to this change since it only modifies the release assertions.
Comment 8 Ryosuke Niwa 2017-10-24 00:23:51 PDT 
Comment on attachment 324638 [details]
Tighens the assertion

Oops, I meant to set cq+ on another patch.
Comment 9 WebKit Commit Bot 2017-10-24 01:54:46 PDT 
Comment on attachment 324638 [details]
Tighens the assertion

Clearing flags on attachment: 324638

Committed r223886: <https://trac.webkit.org/changeset/223886>
Comment 10 WebKit Commit Bot 2017-10-24 01:54:48 PDT 
All reviewed patches have been landed.  Closing bug.