Bug 178659

Summary:

Remember previous child renderer during render tree update

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, commit-queue, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews114 for mac-elcapitan	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
patch	none

Antti Koivisto

Reported 2017-10-23 05:57:45 PDT

We shouldn't need to compute previous renderer, we should know it already.

Attachments
patch (6.57 KB, patch) 2017-10-23 06:00 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.01 MB, application/zip) 2017-10-23 06:59 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.21 MB, application/zip) 2017-10-23 07:05 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-elcapitan (1.80 MB, application/zip) 2017-10-23 07:14 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (4.15 MB, application/zip) 2017-10-23 07:31 PDT, Build Bot	no flags	Details
patch (9.91 KB, patch) 2017-10-23 08:42 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2017-10-23 06:00:17 PDT

Created attachment 324551 [details] patch

Build Bot

Comment 2 2017-10-23 06:59:20 PDT

Comment on attachment 324551 [details] patch Attachment 324551 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4958163 New failing tests: fast/block/float/float-not-removed-from-pre-block.html fast/css-generated-content/details-summary-before-after.html

Build Bot

Comment 3 2017-10-23 06:59:21 PDT

Created attachment 324552 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-10-23 07:05:06 PDT

Comment on attachment 324551 [details] patch Attachment 324551 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4958171 New failing tests: fast/block/float/float-not-removed-from-pre-block.html fast/css-generated-content/details-summary-before-after.html

Build Bot

Comment 5 2017-10-23 07:05:08 PDT

Created attachment 324553 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-10-23 07:14:32 PDT

Comment on attachment 324551 [details] patch Attachment 324551 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4958176 New failing tests: fast/block/float/float-not-removed-from-pre-block.html fast/css-generated-content/details-summary-before-after.html

Build Bot

Comment 7 2017-10-23 07:14:33 PDT

Created attachment 324554 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-10-23 07:31:26 PDT

Comment on attachment 324551 [details] patch Attachment 324551 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4958200 New failing tests: fast/block/float/float-not-removed-from-pre-block.html

Build Bot

Comment 9 2017-10-23 07:31:28 PDT

Created attachment 324555 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Antti Koivisto

Comment 10 2017-10-23 08:42:05 PDT

Created attachment 324559 [details] patch

WebKit Commit Bot

Comment 11 2017-10-23 11:59:10 PDT

Comment on attachment 324559 [details] patch Clearing flags on attachment: 324559 Committed r223848: <https://trac.webkit.org/changeset/223848>

WebKit Commit Bot

Comment 12 2017-10-23 11:59:12 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 13 2017-11-15 13:07:23 PST

<rdar://problem/35568826>

Note You need to log in before you can comment on or make changes to this bug.