Bug 17865

Summary: [Gtk] Improve detection jpeglib
Product: WebKit Reporter: Jan Alonzo <jmalonzo>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alp, mrowe, uws+webkit
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
improve detection of jpeglib and glib tools
none
updated: copy the way gtk detects jpeglib mrowe: review+

Jan Alonzo
Reported 2008-03-15 12:22:48 PDT
The (attached) patch will throw an error if jpeglib and glib tools (glib-genmarshal and glib-mkenums) are not available.
Attachments
improve detection of jpeglib and glib tools (1.28 KB, patch)
2008-03-15 12:23 PDT, Jan Alonzo 		no flags
DetailsFormatted DiffDiff
updated: copy the way gtk detects jpeglib (1.85 KB, patch)
2008-07-25 20:10 PDT, Jan Alonzo 		mrowe: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jan Alonzo
Comment 1 2008-03-15 12:23:28 PDT
Created attachment 19782 [details] improve detection of jpeglib and glib tools
Mark Rowe (bdash)
Comment 2 2008-04-10 17:41:26 PDT
*** Bug 18396 has been marked as a duplicate of this bug. ***
Alp Toker
Comment 3 2008-04-17 12:22:26 PDT
Comment on attachment 19782 [details] improve detection of jpeglib and glib tools r=me, will clear up the grammar a bit before landing.
Alp Toker
Comment 4 2008-04-17 12:24:00 PDT
Landed in r32008.
Alp Toker
Comment 5 2008-04-17 16:01:57 PDT
This worked on my system but failed on the build bot, so backing out the jpeg check. checking pthread.h usability... yes checking pthread.h presence... yes checking for pthread.h... yes checking jpeglib.h usability... no checking jpeglib.h presence... no checking for jpeglib.h... no configure: error: libjpeg is required to build WebKit
Jan Alonzo
Comment 6 2008-04-17 19:50:34 PDT
Hi Alp Is jpeglib installed in a non-standard location?
Mark Rowe (bdash)
Comment 7 2008-04-19 19:48:33 PDT
Comment on attachment 19782 [details] improve detection of jpeglib and glib tools Clearing review flag as this was rolled out.
Wouter Bolsterlee
Comment 8 2008-07-15 05:45:03 PDT
Perhaps something like AC_CHECK_LIB(jpeg, jpeg_destroy_decompress, ...) makes more sense? That's what GTK+ checks for by default as well, afaics.
Jan Alonzo
Comment 9 2008-07-25 20:10:45 PDT
Created attachment 22493 [details] updated: copy the way gtk detects jpeglib
Mark Rowe (bdash)
Comment 10 2008-07-26 21:46:02 PDT
Comment on attachment 22493 [details] updated: copy the way gtk detects jpeglib r=me
Jan Alonzo
Comment 11 2008-07-26 23:01:39 PDT
landed in r35398
Note You need to log in before you can comment on or make changes to this bug.