Bug 17865

Summary: [Gtk] Improve detection jpeglib
Product: WebKit Reporter: Jan Alonzo <jmalonzo>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alp, mrowe, uws+webkit
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
improve detection of jpeglib and glib tools
none
updated: copy the way gtk detects jpeglib mrowe: review+

Description Jan Alonzo 2008-03-15 12:22:48 PDT
The (attached) patch will throw an error if jpeglib and glib tools (glib-genmarshal and glib-mkenums) are not available.
Comment 1 Jan Alonzo 2008-03-15 12:23:28 PDT
Created attachment 19782 [details]
improve detection of jpeglib and glib tools
Comment 2 Mark Rowe (bdash) 2008-04-10 17:41:26 PDT
*** Bug 18396 has been marked as a duplicate of this bug. ***
Comment 3 Alp Toker 2008-04-17 12:22:26 PDT
Comment on attachment 19782 [details]
improve detection of jpeglib and glib tools

r=me, will clear up the grammar a bit before landing.
Comment 4 Alp Toker 2008-04-17 12:24:00 PDT
Landed in r32008.
Comment 5 Alp Toker 2008-04-17 16:01:57 PDT
This worked on my system but failed on the build bot, so backing out the jpeg check.

checking pthread.h usability... yes
checking pthread.h presence... yes
checking for pthread.h... yes
checking jpeglib.h usability... no
checking jpeglib.h presence... no
checking for jpeglib.h... no
configure: error: libjpeg is required to build WebKit
Comment 6 Jan Alonzo 2008-04-17 19:50:34 PDT
Hi Alp

Is jpeglib installed in a non-standard location?
Comment 7 Mark Rowe (bdash) 2008-04-19 19:48:33 PDT
Comment on attachment 19782 [details]
improve detection of jpeglib and glib tools

Clearing review flag as this was rolled out.
Comment 8 Wouter Bolsterlee 2008-07-15 05:45:03 PDT
Perhaps something like AC_CHECK_LIB(jpeg, jpeg_destroy_decompress, ...) makes more sense? That's what GTK+ checks for by default as well, afaics.
Comment 9 Jan Alonzo 2008-07-25 20:10:45 PDT
Created attachment 22493 [details]
updated: copy the way gtk detects jpeglib
Comment 10 Mark Rowe (bdash) 2008-07-26 21:46:02 PDT
Comment on attachment 22493 [details]
updated: copy the way gtk detects jpeglib

r=me
Comment 11 Jan Alonzo 2008-07-26 23:01:39 PDT
landed in r35398