| Summary: | [Web Animations] Add animations to the timeline | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||
| Component: | Animations | Assignee: | Antoine Quint <graouts> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | buildbot, cdumez, commit-queue, dino, esprehn+autocc, kondapallykalyan, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=122912 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Antoine Quint
2017-10-22 05:22:26 PDT
Created attachment 324524 [details]
Patch
Created attachment 324525 [details]
Patch
Created attachment 324529 [details]
Patch
Comment on attachment 324529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324529&action=review > Source/WebCore/animation/AnimationTimeline.cpp:60 > + stream << (m_classType == DocumentTimelineClass ? "DocumentTimeline" : "AnimationTimeline") << " with " << m_animations.size() << " animations:"; > + stream << "\n"; why not put this on the previous line? > Source/WebCore/animation/AnimationTimeline.cpp:64 > + stream << count << ". " << animation->description(); > + stream << "\n"; same Comment on attachment 324529 [details] Patch Clearing flags on attachment: 324529 Committed r223825: <https://trac.webkit.org/changeset/223825> All reviewed patches have been landed. Closing bug. |