Summary: | Web Inspector: Support `async test() { ... }` in Inspector Test Suites | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2017-10-20 21:32:39 PDT
(In reply to Joseph Pecoraro from comment #0) > Support `async test() { ... }` in Inspector Test Suites > > So we can use `await` in test code. 😍 Created attachment 324485 [details]
[PATCH] Proposed Fix
Created attachment 324486 [details]
[PATCH] Proposed Fix
Comment on attachment 324486 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=324486&action=review r=me. One typo. Also waiting on the tests to make sure it's all good :) > LayoutTests/inspector/unit-tests/async-test-suite.html:445 > + description: "Check that an async suite with async test functions that throws with a runtime erorr will reject", Typo. "erorr" -> "error" > Source/WebInspectorUI/UserInterface/Test/TestSuite.js:153 > + if (testcase.test.toString().startsWith("async ")) This feels hacky, but I'm not sure if there's any other way around it :| Created attachment 324490 [details]
[PATCH] For Landing
Comment on attachment 324486 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=324486&action=review >> Source/WebInspectorUI/UserInterface/Test/TestSuite.js:153 >> + if (testcase.test.toString().startsWith("async ")) > > This feels hacky, but I'm not sure if there's any other way around it :| Switched to: if (testcase.test[Symbol.toStringTag] === "AsyncFunction") Comment on attachment 324490 [details] [PATCH] For Landing Clearing flags on attachment: 324490 Committed r223809: <https://trac.webkit.org/changeset/223809> |