Bug 178614 – Web Inspector: Support `async test() { ... }` in Inspector Test Suites

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

Support `async test() { ... }` in Inspector Test Suites

So we can use `await` in test code.

[Devin Rousso]

(In reply to Joseph Pecoraro from comment #0)
> Support `async test() { ... }` in Inspector Test Suites
> 
> So we can use `await` in test code.
😍

[Joseph Pecoraro]

Created attachment 324485 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 324486 [details]
[PATCH] Proposed Fix

[Devin Rousso]

Comment on attachment 324486 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=324486&action=review

r=me.  One typo.  Also waiting on the tests to make sure it's all good :)

> LayoutTests/inspector/unit-tests/async-test-suite.html:445
> +        description: "Check that an async suite with async test functions that throws with a runtime erorr will reject",

Typo.  "erorr" -> "error"

> Source/WebInspectorUI/UserInterface/Test/TestSuite.js:153
> +                if (testcase.test.toString().startsWith("async "))

This feels hacky, but I'm not sure if there's any other way around it :|

[Joseph Pecoraro]

Created attachment 324490 [details]
[PATCH] For Landing

[Joseph Pecoraro]

Comment on attachment 324486 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=324486&action=review

>> Source/WebInspectorUI/UserInterface/Test/TestSuite.js:153
>> +                if (testcase.test.toString().startsWith("async "))
> 
> This feels hacky, but I'm not sure if there's any other way around it :|

Switched to:

    if (testcase.test[Symbol.toStringTag] === "AsyncFunction")

[WebKit Commit Bot]

Comment on attachment 324490 [details]
[PATCH] For Landing

Clearing flags on attachment: 324490

Committed r223809: <https://trac.webkit.org/changeset/223809>

[Radar WebKit Bug Importer]

<rdar://problem/35568648>