Bug 178602

Summary:

Deny new executable mapping after initial execute mapping

Product:

WebKit

Reporter:

JF Bastien <jfbastien>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

buildbot, fpizlo, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	msaboff: review+, jfbastien: commit-queue-
patch	jfbastien: commit-queue-

JF Bastien

Reported 2017-10-20 13:11:05 PDT

Attachments
patch (43.56 KB, patch) 2017-10-20 13:17 PDT, JF Bastien	no flags	Details Formatted Diff Diff
patch (43.39 KB, patch) 2017-10-20 13:27 PDT, JF Bastien	msaboff: review+ jfbastien: commit-queue-	Details Formatted Diff Diff
patch (43.40 KB, patch) 2017-10-20 13:56 PDT, JF Bastien	jfbastien: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

JF Bastien

Comment 1 2017-10-20 13:11:55 PDT

<rdar://problem/35081590>

JF Bastien

Comment 2 2017-10-20 13:17:18 PDT

Created attachment 324438 [details] patch

Michael Saboff

Comment 3 2017-10-20 13:21:22 PDT

Comment on attachment 324438 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=324438&action=review > Source/JavaScriptCore/ChangeLog:3 > + Deny new executable mapping after initial X mapping Change X to executable. > Source/JavaScriptCore/ChangeLog:10 > + Lock down X page protection once we've obtained our one executable > + range. Further X mappings should fail. Ditto

JF Bastien

Comment 4 2017-10-20 13:27:08 PDT

Created attachment 324439 [details] patch cq- for now, I want to test a bit.

Build Bot

Comment 5 2017-10-20 13:29:08 PDT

Attachment 324439 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebKit/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] Total errors found: 5 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Michael Saboff

Comment 6 2017-10-20 13:34:05 PDT

Comment on attachment 324439 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=324439&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + Lock down X page protection once we've obtained our one executable Change X to executable.

Mark Lam

Comment 7 2017-10-20 13:37:23 PDT

Comment on attachment 324439 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=324439&action=review > Source/JavaScriptCore/jit/ExecutableAllocator.cpp:338 > + void lockdownFurtherExecAllocations() > + { > + } nit: since this is an empty function, you can express it in a single line like so: void lockdownFurtherExecAllocations() { }

JF Bastien

Comment 8 2017-10-20 13:56:36 PDT

Created attachment 324442 [details] patch Patch for landing. Still need some live-testing.

Build Bot

Comment 9 2017-10-21 02:53:50 PDT

Attachment 324442 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebKit/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] ERROR: Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible. [featuredefines/equality] [5] Total errors found: 5 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Note You need to log in before you can comment on or make changes to this bug.