Bug 178592
| Summary: | [Regression] test262.yaml/test262/test/language/statements/try/tco-catch.js.default-strict is failing on Test262 consistently. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Lewis <jlewis3> |
| Component: | JavaScriptCore | Assignee: | Robin Morisset <rmorisset> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | rmorisset, ryanhaddad, saam |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=176703 | ||
Matt Lewis
test262.yaml/test262/test/language/statements/try/tco-catch.js.default-strict is failing consistently on the Test262 tester according to the Archived runs.
https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20Test262%20(Tests)?numbuilds=50
It started failing after https://trac.webkit.org/changeset/223691/webkit
failure:
test262.yaml/test262/test/language/statements/try/tco-catch.js.default-strict: ERROR: Unexpected exit code: 0
FAIL: test262.yaml/test262/test/language/statements/try/tco-catch.js.default-strict
log:
https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20Test262%20%28Tests%29/builds/3943/steps/test262-test/logs/stdio
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Robin Morisset
Thanks for reporting it, I will look into it.
Robin Morisset
I spent some time trying to reproduce this bug and not understanding why it only triggered when using the testing harness and not when running the program by hand.
After looking at JSTests/test262.yaml in more details, I saw that this program was marked :fail, so visibly it was expected that the test would fail, and the testing harness is now complaining that it no longer does. This assumption was last changed in https://bugs.webkit.org/show_bug.cgi?id=177859.
Interestingly, increasing the number of iterations to 100000 makes the test fail with stack overflow. This looks possibly related to https://bugs.webkit.org/show_bug.cgi?id=176703.
Ryan Haddad
The bot has been red for days due to this issue. Should we go ahead and mark the test as passing?
Ryan Haddad
I confirmed with Robin that we should mark the test as passing.
Made the change in https://trac.webkit.org/changeset/223961/webkit
Ryan Haddad
Reverted r223961 for reason:
The change that required this has been rolled out.
Committed r224022: <https://trac.webkit.org/changeset/224022>
Ryan Haddad
Duping to the bug that caused this.
*** This bug has been marked as a duplicate of bug 176601 ***