Summary: | When destroying a resource, register "only" the clients who are losing their resource as having pending resources | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||
Component: | SVG | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, simon.fraser, thorton, webkit-bug-importer, zimmermann | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Said Abou-Hallawa
2017-10-19 22:11:18 PDT
Created attachment 324358 [details]
Patch
Comment on attachment 324358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324358&action=review > Source/WebCore/rendering/svg/SVGResources.cpp:391 > m_clipperFilterMaskerData->masker = 0; These 0 should all be nullptr, right? > Source/WebCore/rendering/svg/SVGResources.h:70 > + bool resourceDestroyed(RenderSVGResourceContainer&); Please add a comment saying what the return value means, or use an enum. Created attachment 324424 [details]
Patch
Comment on attachment 324424 [details] Patch Clearing flags on attachment: 324424 Committed r223789: <https://trac.webkit.org/changeset/223789> All reviewed patches have been landed. Closing bug. |