Bug 178531

Summary: We should hard code the poly proto offset
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
might be the patch
none
test on EWS
none
patch
fpizlo: review+
patch for landing saam: commit-queue-

Saam Barati
Reported 2017-10-19 12:18:49 PDT
Currently, it's always at offset zero in inline storage. Let's make this a hard coded assumption because it speeds up speedometer.
Attachments
might be the patch (19.19 KB, patch)
2017-10-19 13:07 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
test on EWS (21.62 KB, patch)
2017-10-19 13:09 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (23.88 KB, patch)
2017-10-19 14:22 PDT, Saam Barati 		fpizlo: review+
DetailsFormatted DiffDiff
patch for landing (23.80 KB, patch)
2017-10-19 14:33 PDT, Saam Barati 		saam: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2017-10-19 13:07:02 PDT
Created attachment 324267 [details] might be the patch
Saam Barati
Comment 2 2017-10-19 13:09:58 PDT
Created attachment 324269 [details] test on EWS
Saam Barati
Comment 3 2017-10-19 14:22:04 PDT
Created attachment 324283 [details] patch
Mark Lam
Comment 4 2017-10-19 14:31:44 PDT
Comment on attachment 324283 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=324283&action=review > Source/JavaScriptCore/bytecode/AccessCase.cpp:450 > + RELEASE_ASSERT(isInlineOffset(knownPolyProtoOffset)); Remove this.
Saam Barati
Comment 5 2017-10-19 14:33:13 PDT
Created attachment 324292 [details] patch for landing
Saam Barati
Comment 6 2017-10-19 15:02:41 PDT
need to fix some debug asserts.
Saam Barati
Comment 7 2017-10-19 15:24:17 PDT
landed in: https://trac.webkit.org/changeset/223715/webkit
Radar WebKit Bug Importer
Comment 8 2017-11-15 13:02:10 PST
<rdar://problem/35568656>
Note You need to log in before you can comment on or make changes to this bug.