Bug 178531

Summary: We should hard code the poly proto offset
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
might be the patch
none
test on EWS
none
patch
fpizlo: review+
patch for landing saam: commit-queue-

Description Saam Barati 2017-10-19 12:18:49 PDT
Currently, it's always at offset zero in inline storage. Let's make this a hard coded assumption because it speeds up speedometer.
Comment 1 Saam Barati 2017-10-19 13:07:02 PDT
Created attachment 324267 [details]
might be the patch
Comment 2 Saam Barati 2017-10-19 13:09:58 PDT
Created attachment 324269 [details]
test on EWS
Comment 3 Saam Barati 2017-10-19 14:22:04 PDT
Created attachment 324283 [details]
patch
Comment 4 Mark Lam 2017-10-19 14:31:44 PDT
Comment on attachment 324283 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324283&action=review

> Source/JavaScriptCore/bytecode/AccessCase.cpp:450
> +                        RELEASE_ASSERT(isInlineOffset(knownPolyProtoOffset));

Remove this.
Comment 5 Saam Barati 2017-10-19 14:33:13 PDT
Created attachment 324292 [details]
patch for landing
Comment 6 Saam Barati 2017-10-19 15:02:41 PDT
need to fix some debug asserts.
Comment 7 Saam Barati 2017-10-19 15:24:17 PDT
landed in:
https://trac.webkit.org/changeset/223715/webkit
Comment 8 Radar WebKit Bug Importer 2017-11-15 13:02:10 PST
<rdar://problem/35568656>