Bug 178516

Summary: [Win] Switch to VS2017 on EWS bots.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: Tools / TestsAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, bfulgham, commit-queue, darin, dbates, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+, commit-queue: commit-queue-

Per Arne Vollan
Reported 2017-10-19 08:29:05 PDT
I believe we are ready to switch to VS2017 on EWS.
Attachments
Patch (1.32 KB, patch)
2017-10-19 08:30 PDT, Per Arne Vollan 		darin: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2017-10-19 08:30:14 PDT
Created attachment 324236 [details] Patch
Per Arne Vollan
Comment 2 2017-11-27 08:32:07 PST
Comment on attachment 324236 [details] Patch Thanks for reviewing!
WebKit Commit Bot
Comment 3 2017-11-27 08:33:24 PST
Comment on attachment 324236 [details] Patch Rejecting attachment 324236 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 324236, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: r']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/EWSTools/start-queue-win.sh Hunk #1 succeeded at 19 with fuzz 2. Hunk #2 FAILED at 31. 1 out of 2 hunks FAILED -- saving rejects to file Tools/EWSTools/start-queue-win.sh.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/5375327
Per Arne Vollan
Comment 4 2017-11-27 09:20:29 PST
Committed r225177: <https://trac.webkit.org/changeset/225177/webkit>.
Radar WebKit Bug Importer
Comment 5 2017-11-27 09:21:26 PST
<rdar://problem/35699196>
Note You need to log in before you can comment on or make changes to this bug.