Bug 178481 – webkitpy tests should have --json-output option

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Aakash Jain]

webkitpy tests should have --json-output option which would write the json results to a json output file. This would help in developing an EWS which would run webkitpy tests and parse the output from json output file.

Many other scripts like "run-api-tests", "run-bindings-tests", "run-javascriptcore-tests" have "json-output" parameter which is used by corresponding EWSes.

[Aakash Jain]

Created attachment 324152 [details]
Proposed patch

[Alexey Proskuryakov]

Comment on attachment 324152 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324152&action=review

> Tools/Scripts/webkitpy/test/main.py:123
>          parser.add_option('--json', action='store_true', default=False,
>                            help='write JSON formatted test results to stdout')
> +        parser.add_option('--json-output', action='store', type='string', dest='json_file_name',
> +                          help='Create a file at specified path, listing test results in JSON format.')

I think that we need at least a fixme to clean this up. Standard output is just a kind of file, so having two options is unnecessary and highly unusual.

Better yet, mark the old one as deprecated, and better yet, remove it.

[Aakash Jain]

Created attachment 324160 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 324160 [details]
Patch for landing

Rejecting attachment 324160 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 324160, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
'--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/Scripts/webkitpy/test/main.py
Hunk #1 FAILED at 117.
Hunk #2 succeeded at 187 with fuzz 2 (offset 8 lines).
1 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/test/main.py.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/4908490

[Aakash Jain]

Committed r223630: <https://trac.webkit.org/changeset/223630>

[Radar WebKit Bug Importer]

<rdar://problem/35061458>