Bug 178388 – [GTK] Inspector UI does not use system font despite -webkit-system-font being supported

• Component: Web Inspector
• Status: RESOLVED FIXED

[Adrian Perez]

After solving bug #177755 the GTK+ port has support for “-webkit-system-font”
but the Web Inspector user interface does not seem to be picking the system
font, e.g. an undescript sans-serif font will still be used despite Cantarell
being the default font under GNOME 3.

[Adrian Perez]

A cursory glance reveals that many CSS style sheets for the
Web Inspector use the following “font-family” declarations:

  -webkit-system-font
  -apple-system-font
  -apple-system

In the GTK+ port we only support “-webkit-system-font”, which
causes the “sans-serif” fallback to kick in. There are two
possible solutions:

  1. Use -webkit-system-font everywhere.
  2. Support -apple-system(-font) in the GTK+ port.

Personally I prefer to avoid (2.) because from the correctness
point of view one could expect that “-apple-system(-font)” picks
the UI font used by Apple, despite of which WebKit port (that's
also the reason why I didn't implement the “-apple-” prefixes
in the patch for bug #177755 — it doesn't make sense for GTK+).

[Adrian Perez]

Created attachment 324036 [details]
Patch

[Adrian Perez]

Created attachment 324038 [details]
MiniBrowser showing the inspector under GNOME 3 with patch applied (system font = Cantarell)

The Inspector UI blends much more nicely with the rest of the desktop
with the attached patch applied ♥

[Joseph Pecoraro]

Comment on attachment 324036 [details]
Patch

This exact thought crossed my mind last week when I added a new instance of -webkit-system-font! This sounds good to me.

[WebKit Commit Bot]

Comment on attachment 324036 [details]
Patch

Clearing flags on attachment: 324036

Committed r223694: <https://trac.webkit.org/changeset/223694>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35568792>